This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Don't error for uniform dynamic alloca on DAG path
Needs ReviewPublic

Authored by arsenm on Aug 17 2023, 7:59 AM.

Details

Reviewers
scott.linder
cdevadas
yassingh
pravinjagtap
Group Reviewers
Restricted Project
Summary

This is more consistent with the globalisel handling. This still won't
work correctly in a function (it might work inside kernels).

Also add some tests to cover restore of SP (which is currently broken,
in most of the cases).

Diff Detail

Event Timeline

arsenm created this revision.Aug 17 2023, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2023, 7:59 AM
arsenm requested review of this revision.Aug 17 2023, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2023, 7:59 AM
Herald added a subscriber: wdng. · View Herald Transcript
cdevadas added inline comments.Aug 17 2023, 8:14 AM
llvm/test/CodeGen/AMDGPU/dynamic_stackalloc.ll
2

Why both -march and -mtriple?

arsenm updated this revision to Diff 555003.Aug 31 2023, 5:51 AM
arsenm marked an inline comment as done.