This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][True16] Update FPToI1Pat GFX11 pat to use GFX11 instruction
ClosedPublic

Authored by Joe_Nash on Aug 14 2023, 12:34 PM.

Details

Summary

These cmp patterns were using the pre-GFX11 pseudo instruction, and so
failed to compile.

Diff Detail

Event Timeline

Joe_Nash created this revision.Aug 14 2023, 12:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2023, 12:34 PM
Joe_Nash requested review of this revision.Aug 14 2023, 12:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2023, 12:34 PM

Without the tablegen change, the test results in "Assertion `Opcode < NumOpcodes && "Invalid opcode!"". I don't know why the GFX11 compilation issue was not detected by runtime testing. Perhaps the generated IR is not emitted by any frontend? It's not related to unsafe-fp-math, the same issue arises without the flag.

foad accepted this revision.Aug 15 2023, 2:10 AM
This revision is now accepted and ready to land.Aug 15 2023, 2:10 AM