This is an archive of the discontinued LLVM Phabricator instance.

Differential D157895

InstSimplify: Handle log10(exp10(x))
ClosedPublic

Authored by arsenm on Aug 14 2023, 8:47 AM.

Details

Reviewers
jcranmer-intel
foad
kpn
andrew.w.kaylor
sepavloff
Summary

Copied from the exp/exp2 cases

Diff Detail

Event Timeline

arsenm created this revision.Aug 14 2023, 8:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2023, 8:47 AM
Herald added subscribers: StephenFan, hiraditya. · View Herald Transcript
arsenm requested review of this revision.Aug 14 2023, 8:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2023, 8:47 AM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm added a parent revision: D157894: InstSimplify: Handle exp10(log10(x)) -> x.Aug 14 2023, 8:47 AM
Harbormaster completed remote builds in B252387: Diff 549974.Aug 14 2023, 8:49 AM
kpn accepted this revision.Aug 14 2023, 11:31 AM

LGTM.

This revision is now accepted and ready to land.Aug 14 2023, 11:31 AM
arsenm closed this revision.Sep 2 2023, 6:27 AM

da077a52c46a8d95f3e1bf060cfc199f76556f2d

Revision Contents

PathSize
llvm/
lib/
Analysis/
5 lines
test/
Transforms/
InstSimplify/
10 lines

Diff 549974

llvm/lib/Analysis/InstructionSimplify.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 6,169 Lines • ▼ Show 20 Lines case Intrinsic::log2:
if (Q.CxtI->hasAllowReassoc() && if (Q.CxtI->hasAllowReassoc() &&
(match(Op0, m_Intrinsic<Intrinsic::exp2>(m_Value(X))) || (match(Op0, m_Intrinsic<Intrinsic::exp2>(m_Value(X))) ||
match(Op0, match(Op0,
m_Intrinsic<Intrinsic::pow>(m_SpecificFP(2.0), m_Value(X))))) m_Intrinsic<Intrinsic::pow>(m_SpecificFP(2.0), m_Value(X)))))
return X; return X;
break; break;
case Intrinsic::log10: case Intrinsic::log10:
// log10(pow(10.0, x)) -> x // log10(pow(10.0, x)) -> x
// log10(exp10(x)) -> x
if (Q.CxtI->hasAllowReassoc() && if (Q.CxtI->hasAllowReassoc() &&
match(Op0, m_Intrinsic<Intrinsic::pow>(m_SpecificFP(10.0), m_Value(X)))) (match(Op0, m_Intrinsic<Intrinsic::exp10>(m_Value(X))) ||
match(Op0,
m_Intrinsic<Intrinsic::pow>(m_SpecificFP(10.0), m_Value(X)))))
return X; return X;
break; break;
case Intrinsic::experimental_vector_reverse: case Intrinsic::experimental_vector_reverse:
// experimental.vector.reverse(experimental.vector.reverse(x)) -> x // experimental.vector.reverse(experimental.vector.reverse(x)) -> x
if (match(Op0, m_VecReverse(m_Value(X)))) if (match(Op0, m_VecReverse(m_Value(X))))
return X; return X;
// experimental.vector.reverse(splat(X)) -> splat(X) // experimental.vector.reverse(splat(X)) -> splat(X)
if (isSplatValue(Op0)) if (isSplatValue(Op0))
▲ Show 20 Lines • Show All 886 Lines • Show Last 20 Lines

llvm/test/Transforms/InstSimplify/log-exp-intrinsic.ll

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Lines;
%2 = call reassoc double @llvm.exp2.f64(double %1) %2 = call reassoc double @llvm.exp2.f64(double %1)
%3 = call double @llvm.log2.f64(double %2) %3 = call double @llvm.log2.f64(double %2)
%4 = call reassoc double @llvm.exp2.f64(double %3) %4 = call reassoc double @llvm.exp2.f64(double %3)
ret double %4 ret double %4
} }
define double @log10_reassoc_exp10_strict(double %a) { define double @log10_reassoc_exp10_strict(double %a) {
; CHECK-LABEL: @log10_reassoc_exp10_strict( ; CHECK-LABEL: @log10_reassoc_exp10_strict(
; CHECK-NEXT: [[TMP1:%.*]] = call double @llvm.exp10.f64(double [[A:%.*]]) ; CHECK-NEXT: ret double [[A:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = call reassoc double @llvm.log10.f64(double [[TMP1]])
; CHECK-NEXT: ret double [[TMP2]]
; ;
%1 = call double @llvm.exp10.f64(double %a) %1 = call double @llvm.exp10.f64(double %a)
%2 = call reassoc double @llvm.log10.f64(double %1) %2 = call reassoc double @llvm.log10.f64(double %1)
ret double %2 ret double %2
} }
define double @log10_strict_exp10_reassoc(double %a) { define double @log10_strict_exp10_reassoc(double %a) {
; CHECK-LABEL: @log10_strict_exp10_reassoc( ; CHECK-LABEL: @log10_strict_exp10_reassoc(
Show All 18 Lines;
%2 = call double @llvm.log10.f64(double %1) %2 = call double @llvm.log10.f64(double %1)
%3 = call double @llvm.exp10.f64(double %2) %3 = call double @llvm.exp10.f64(double %2)
%4 = call double @llvm.log10.f64(double %3) %4 = call double @llvm.log10.f64(double %3)
ret double %4 ret double %4
} }
define double @log10_exp10_log10_exp10_reassoc(double %a) { define double @log10_exp10_log10_exp10_reassoc(double %a) {
; CHECK-LABEL: @log10_exp10_log10_exp10_reassoc( ; CHECK-LABEL: @log10_exp10_log10_exp10_reassoc(
; CHECK-NEXT: [[TMP1:%.*]] = call double @llvm.exp10.f64(double [[A:%.*]]) ; CHECK-NEXT: ret double [[A:%.*]]
; CHECK-NEXT: [[TMP2:%.*]] = call reassoc double @llvm.log10.f64(double [[TMP1]])
; CHECK-NEXT: [[TMP3:%.*]] = call double @llvm.exp10.f64(double [[TMP2]])
; CHECK-NEXT: [[TMP4:%.*]] = call reassoc double @llvm.log10.f64(double [[TMP3]])
; CHECK-NEXT: ret double [[TMP4]]
; ;
%1 = call double @llvm.exp10.f64(double %a) %1 = call double @llvm.exp10.f64(double %a)
%2 = call reassoc double @llvm.log10.f64(double %1) %2 = call reassoc double @llvm.log10.f64(double %1)
%3 = call double @llvm.exp10.f64(double %2) %3 = call double @llvm.exp10.f64(double %2)
%4 = call reassoc double @llvm.log10.f64(double %3) %4 = call reassoc double @llvm.log10.f64(double %3)
ret double %4 ret double %4
} }
▲ Show 20 Lines • Show All 78 Lines • Show Last 20 Lines