This is an archive of the discontinued LLVM Phabricator instance.

Differential D157857

[AMDGPU] Make VOPD insts with a FMAMK or FMAMK component have a fixed size
ClosedPublic

Authored by mbrkusanin on Aug 14 2023, 4:14 AM.

Details

Reviewers
foad
arsenm
Joe_Nash
RKSimon
Commits
rG6e86ab7e4ff9: [AMDGPU] Make VOPD insts with a FMAMK or FMAMK component have a fixed size
Summary

This fixes a failure from the expensive-checks buildbot

Diff Detail

Event Timeline

mbrkusanin created this revision.Aug 14 2023, 4:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2023, 4:14 AM
Herald added subscribers: StephenFan, kerbowa, hiraditya and 5 others. · View Herald Transcript
mbrkusanin requested review of this revision.Aug 14 2023, 4:14 AM
Herald added a subscriber: wdng. · View Herald TranscriptAug 14 2023, 4:14 AM
mbrkusanin mentioned this in D157624: [AMDGPU] Treat KIMM32 and KIMM16 operand types as noninlinable.Aug 14 2023, 4:15 AM
arsenm accepted this revision.Aug 14 2023, 4:28 AM
This revision is now accepted and ready to land.Aug 14 2023, 4:28 AM
This revision was landed with ongoing or failed builds.Aug 14 2023, 4:35 AM
Closed by commit rG6e86ab7e4ff9: [AMDGPU] Make VOPD insts with a FMAMK or FMAMK component have a fixed size (authored by mbrkusanin). · Explain Why
This revision was automatically updated to reflect the committed changes.
mbrkusanin added a commit: rG6e86ab7e4ff9: [AMDGPU] Make VOPD insts with a FMAMK or FMAMK component have a fixed size.
RKSimon added a comment.Aug 14 2023, 5:14 AM

Thanks @mbrkusanin

Harbormaster completed remote builds in B252306: Diff 549867.Aug 14 2023, 6:29 AM

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
1 line

Diff 549877

llvm/lib/Target/AMDGPU/VOPDInstructions.td

Show First 20 Lines • Show All 105 Lines • ▼ Show 20 Lines
class VOPD_MADK<dag outs, dag ins, string asm, VOP_Pseudo VDX, VOP_Pseudo VDY, class VOPD_MADK<dag outs, dag ins, string asm, VOP_Pseudo VDX, VOP_Pseudo VDY,
VOPD_Component XasVC, VOPD_Component YasVC> VOPD_Component XasVC, VOPD_Component YasVC>
: VOPD_Base<outs, ins, asm, VDX, VDY, XasVC, YasVC>, : VOPD_Base<outs, ins, asm, VDX, VDY, XasVC, YasVC>,
VOPD_MADKe<XasVC.VOPDOp{3-0}, YasVC.VOPDOp> { VOPD_MADKe<XasVC.VOPDOp{3-0}, YasVC.VOPDOp> {
let Inst{16-9} = !if (!eq(VDX.Mnemonic, "v_mov_b32"), 0x0, vsrc1X); let Inst{16-9} = !if (!eq(VDX.Mnemonic, "v_mov_b32"), 0x0, vsrc1X);
let Inst{48-41} = !if (!eq(VDY.Mnemonic, "v_mov_b32"), 0x0, vsrc1Y); let Inst{48-41} = !if (!eq(VDY.Mnemonic, "v_mov_b32"), 0x0, vsrc1Y);
let Size = 12; let Size = 12;
let FixedSize = 1;
} }
// V_DUAL_DOT2ACC_F32_BF16 is a legal instruction, but V_DOT2ACC_F32_BF16 is // V_DUAL_DOT2ACC_F32_BF16 is a legal instruction, but V_DOT2ACC_F32_BF16 is
// not. Since we generate the DUAL form by converting from the normal form we // not. Since we generate the DUAL form by converting from the normal form we
// will never generate it. // will never generate it.
defvar VOPDYPseudos = [ defvar VOPDYPseudos = [
"V_FMAC_F32_e32", "V_FMAAK_F32", "V_FMAMK_F32", "V_MUL_F32_e32", "V_FMAC_F32_e32", "V_FMAAK_F32", "V_FMAMK_F32", "V_MUL_F32_e32",
"V_ADD_F32_e32", "V_SUB_F32_e32", "V_SUBREV_F32_e32", "V_MUL_LEGACY_F32_e32", "V_ADD_F32_e32", "V_SUB_F32_e32", "V_SUBREV_F32_e32", "V_MUL_LEGACY_F32_e32",
▲ Show 20 Lines • Show All 53 Lines • Show Last 20 Lines