Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| llvm/test/CodeGen/AMDGPU/global_atomics_optimizer_fp.ll | ||
|---|---|---|
| 15 ↗ | (On Diff #549371) | you probably want to add some syncscopes to ensure they are preserved (maybe other metadata too) |
| 33–34 ↗ | (On Diff #549371) | you could also just use a regular function and use a function argument |
| 36 ↗ | (On Diff #549371) | Probably should test return and no return variants |
Autogenerate, not autoupgrade in title
| llvm/test/CodeGen/AMDGPU/global_atomic_optimizer_fp_rtn.ll | ||
|---|---|---|
| 9 | this isn't a uniform pointer | |
| llvm/test/CodeGen/AMDGPU/global_atomic_optimizer_fp_rtn.ll | ||
|---|---|---|
| 124 | If you're testing a divergent value, might as well have the pointer be divergent too | |
| 137 | should be a separate strictfp test, the strictfp is hidden | |
| 150 | Typo defalut. Also call it system | |
| llvm/test/CodeGen/AMDGPU/global_atomics_optimizer_fp_no_rtn.ll | ||
| 150 | Ditto for everything in the return version | |
| 166 | Missing space | |
| llvm/test/CodeGen/AMDGPU/global_atomic_optimizer_fp_rtn.ll | ||
|---|---|---|
| 137 | These atomicrmw operations are tested with following attributes and there is separate attribute for strictfp which is #2 attributes #0 = { "denormal-fp-math-f32"="preserve-sign,preserve-sign" "amdgpu-unsafe-fp-atomics"="true" }
attributes #1 = { strictfp "denormal-fp-math-f32"="preserve-sign,preserve-sign" "amdgpu-unsafe-fp-atomics"="true" }
attributes #2 = { strictfp} | |
| llvm/test/CodeGen/AMDGPU/global_atomic_optimizer_fp_rtn.ll | ||
|---|---|---|
| 137 | Which is the function I pointed to, marked with attribute group 2. The test name does not indicate this is a strictfp test and it looks like it's just testing the other combinations of uniformity and scope | |
| llvm/test/CodeGen/AMDGPU/global_atomic_optimizer_fp_rtn.ll | ||
|---|---|---|
| 137 | you want me to mangle the attributes into function name for each of them? And Yes, these tests are the combination of fadd/fsub/fmin/fmax with different scopes and also combination of uniform or divergent input values to atomicrmw (address and value). | |
this isn't a uniform pointer