This is an archive of the discontinued LLVM Phabricator instance.

[Docs] Cleanup pass documentation
ClosedPublic

Authored by aidengrossman on Aug 10 2023, 2:40 PM.

Details

Summary

Currently the pass documentation specifies every pass with a single dash
(-) in front of it as this was the old format for specifying passes with
opt. However, after the transition to the new PM, this syntax is
deprecated. This patch removes all the single dashes from the pass page
to reflect this. Additionally, some previously removed/renamed passes
are removed/updated in the pass list.

Diff Detail

Event Timeline

aidengrossman created this revision.Aug 10 2023, 2:40 PM
Herald added a project: Restricted Project. · View Herald Transcript
aidengrossman requested review of this revision.Aug 10 2023, 2:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 2:40 PM

To look for dead passes I went through all the pass names and looked in the PassRegistry, grepped for the pass name at the time of conversion to restructured text, and at the current tip of tree. If it was in the pass registry, I kept it. If it was only in passes.rst at the time of conversion, I dropped it, and if it was more present I grepped the current tip of tree. If it was only present in passes.rst, I again dropped it, but otherwise kept it for the most part. Some of the functions that I've kept probably need to at least be updated as they either don't support the new pass manager/aren't registered in the pass registry currently, etc.

Some passes have been changed around to new ones (like loop-unswitch to simple-loop-unswitch) and eventually documentation needs to be written up on them, but I'll leave that to a future patch for now.

thanks for doing this!

I think we should be able to copy the loop unswitch docs for simple-loop-unswitch, they do the same thing at a high level, it's just details that differ

Rename loop-unswitch to simple-loop-unswitch rather than removing documentation.

aeubanks accepted this revision.Aug 10 2023, 3:53 PM

lg with nit

llvm/docs/Passes.rst
757–758

should put this alphabetically

This revision is now accepted and ready to land.Aug 10 2023, 3:53 PM
This revision was landed with ongoing or failed builds.Aug 10 2023, 4:19 PM
This revision was automatically updated to reflect the committed changes.