Check iterator validity before use; fixes crash seen when compiling internal benchmark.
Details
Details
Diff Detail
Diff Detail
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
60,070 ms | x64 debian > MLIR.Examples/standalone::test.toy |
Event Timeline
Comment Actions
Fix LGTM. I think it makes some sense to see if a simple test case can be produced as @wangpc suggests - I don't think that's always the case when there's a missing check (as test cases might end up being very specific to the current implementation approach), but it does feel like the fact you encountered this error indicates we don't have enough in-tree testing for this.