[clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

[fwolff]

Summary

Fixes a simple oversight which currently causes the AllowIntegerConditions option of the readability-implicit-bool-conversion check to not apply to do-while loop conditions, for no apparent reason.

[PiotrZSL]

Missing release notes, except that looks fine.
What about switchStmt ?

[fwolff]

Mention this change in the release notes

[PiotrZSL]

clang-tools-extra/docs/ReleaseNotes.rst

199–202 ↗

(On Diff #548334)

[fwolff]

Thanks for reviewing this @PiotrZSL!

In D157428#4570497, @PiotrZSL wrote:

What about switchStmt ?

The AllowIntegerConditions and AllowPointerConditions options only apply to int -> bool conversions, whereas switch statements have integral conditions.

[PiotrZSL]

LGTM

clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp

bool isCastAllowedInCondition(const ImplicitCastExpr *Cast,
   TraversalKindScope RAII(Context, TK_AsIs);
 
   while (!Q.empty()) {
     for (const auto &N : Context.getParents(*Q.front())) {
       const Stmt *S = N.get<Stmt>();
       if (!S)
         return false;
       if (isa<IfStmt>(S) || isa<ConditionalOperator>(S) || isa<ForStmt>(S) ||
-          isa<WhileStmt>(S) || isa<BinaryConditionalOperator>(S))
+          isa<WhileStmt>(S) || isa<DoStmt>(S) ||
+          isa<BinaryConditionalOperator>(S))
         return true;
       if (isa<ParenExpr>(S) || isa<ImplicitCastExpr>(S) ||
           isUnaryLogicalNotOperator(S) ||
           (isa<BinaryOperator>(S) && cast<BinaryOperator>(S)->isLogicalOp())) {
         Q.push(S);
       } else {
         return false;
       }

clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion-allow-in-conditions.cpp

void implicitConversionIntegerToBoolInConditionalsIsAllowed() {
   if (functionReturningInt() && functionReturningPointer()) {}
   if (!functionReturningInt() && !functionReturningPointer()) {}
   for (; functionReturningInt(); ) {}
   for (; functionReturningPointer(); ) {}
   for (; functionReturningInt() && !functionReturningPointer() || (!functionReturningInt() && functionReturningPointer()); ) {}
   while (functionReturningInt()) {}
   while (functionReturningPointer()) {}
   while (functionReturningInt() && !functionReturningPointer() || (!functionReturningInt() && functionReturningPointer())) {}
+  do {} while (functionReturningInt());
+  do {} while (functionReturningPointer());
+  do {} while (functionReturningInt() && !functionReturningPointer() || (!functionReturningInt() && functionReturningPointer()));
   int value1 = functionReturningInt() ? 1 : 2;
   int value2 = !functionReturningInt() ? 1 : 2;
   int value3 = (functionReturningInt() && functionReturningPointer() || !functionReturningInt()) ? 1 : 2;
   int value4 = functionReturningInt() ?: value3;
   int *p1 = functionReturningPointer() ?: &value3;
 }
 
 void regularImplicitConversionPointerToBoolIsNotIgnored() {