This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][DWARF][NFC] Add function to print DIE
ClosedPublic

Authored by ayermolo on Aug 7 2023, 8:31 PM.

Details

Summary

This is purely to make debugging easier for developers. Now that we moved to IR
the print out of DIEs is lacking. This function will lazily parse DIE and use
DWARFDie dump function.

Diff Detail

Event Timeline

ayermolo created this revision.Aug 7 2023, 8:31 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
ayermolo requested review of this revision.Aug 7 2023, 8:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2023, 8:31 PM
Amir accepted this revision.Aug 8 2023, 3:01 PM

LGTM with nits

bolt/lib/Rewrite/DWARFRewriter.cpp
59–60

Remove

68
This revision is now accepted and ready to land.Aug 8 2023, 3:01 PM
ayermolo updated this revision to Diff 548389.Aug 8 2023, 4:03 PM

addressed comments

ayermolo marked 2 inline comments as done.Aug 8 2023, 4:03 PM
This revision was automatically updated to reflect the committed changes.