This is an archive of the discontinued LLVM Phabricator instance.

[Coroutine][DebugInfo] Pre-commit test for a DISubprogram with declaration.
ClosedPublic

Authored by DianQK on Aug 4 2023, 11:38 PM.

Diff Detail

Event Timeline

DianQK created this revision.Aug 4 2023, 11:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2023, 11:38 PM
Herald added a subscriber: ChuanqiXu. · View Herald Transcript
DianQK requested review of this revision.Aug 4 2023, 11:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2023, 11:38 PM
DianQK edited the summary of this revision. (Show Details)Aug 5 2023, 1:35 AM
DianQK added reviewers: aprantl, dblaikie, ChuanqiXu.
DianQK added a reviewer: kastiglione.
This revision was not accepted when it landed; it landed in state Needs Review.Aug 7 2023, 5:26 PM
This revision was automatically updated to reflect the committed changes.
fdeazeve added inline comments.
llvm/test/Transforms/Coroutines/coro-async-declaration.ll
1

Running the entirety of O2 is not ideal for a Transform test, see for example llvm/test/Transforms/Coroutines/swift-async-dbg.ll.

Please also note that a lot of lines in this test are not needed to exercise the behaviour we want to preserve in the subsequent commit

DianQK added inline comments.Aug 16 2023, 3:06 PM
llvm/test/Transforms/Coroutines/coro-async-declaration.ll
1

Thank you. I also thought the test was too big. The original version was actually bigger and I tried to remove irrelevant parts of the test.
May I ask how your test was created? Where is the source code? I guess I could just add a struct to it.

May I ask how your test was created? Where is the source code? I guess I could just add a struct to it.

The test was handwritten, mostly :)

May I ask how your test was created? Where is the source code? I guess I could just add a struct to it.

The test was handwritten, mostly :)

Ok, I chose to try a hand-modified simplification of the generated IR. :)