GFX90A DS instructions cannot use the gds modifier, except for the
DS_GWS_* instructions where it is still mandatory.
Details
Details
- Reviewers
arsenm - Group Reviewers
Restricted Project - Commits
- rG18919ee75954: [AMDGPU] Validate GDS in the assembler
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Note that the disassembler will still happily decode the gds bit. I hope that's OK. The disassembler has always been more forgiving than the assembler.
Comment Actions
I think disasm test lines with gds shall also be removed, even if we still decode and print it.
Comment Actions
I think the disassembler should continue printing it, the disassembler needs to be more tolerant of anything that it sees
llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
4428 | Are there tests that check triggering this message? |
Comment Actions
I removed those lines and added a single test that the disassembler still decodes gds. Is that a reasonable compromise?
llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
---|---|---|
4428 | Good point. There were not. I added one. |
Are there tests that check triggering this message?