This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][DWARF] Delete DW_AT_low_pc when converting to ranges
ClosedPublic

Authored by ayermolo on Aug 2 2023, 5:59 PM.

Details

Summary

Now that we have new DWARF Rewriter we can remove DW_AT_low_pc when converting
DW_AT_low_pc/DW_AT_high_pc to DW_AT_ranges. Which closer follows DWARF spec.
Leaving CU DW_AT_low_pc in place. Reading the spec I think it's needed.

Diff Detail

Event Timeline

ayermolo created this revision.Aug 2 2023, 5:59 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
ayermolo requested review of this revision.Aug 2 2023, 5:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2023, 5:59 PM
maksfb accepted this revision.Aug 3 2023, 1:43 AM

LGTM. Please drop the trailing period from the title before committing.

This revision is now accepted and ready to land.Aug 3 2023, 1:43 AM
ayermolo retitled this revision from [BOLT][DWARF] Delete DW_AT_low_pc when converting to ranges. to [BOLT][DWARF] Delete DW_AT_low_pc when converting to ranges.Aug 3 2023, 7:35 AM