This is an archive of the discontinued LLVM Phabricator instance.

Differential D156734

[BOLT] Fixing macOS build
ClosedPublic

Authored by spupyrev on Jul 31 2023, 1:14 PM.

Details

Reviewers
rafauler
Amir
maksfb
Commits
rG299ec3c22a3b: [BOLT] Fixing macOS build
Summary

Fixing build after https://reviews.llvm.org/D153039

Diff Detail

Event Timeline

spupyrev created this revision.Jul 31 2023, 1:14 PM
Herald added a reviewer: rafauler. · View Herald TranscriptJul 31 2023, 1:14 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: treapster, ayermolo. · View Herald Transcript
spupyrev published this revision for review.Jul 31 2023, 1:14 PM
spupyrev edited the summary of this revision. (Show Details)
spupyrev added a subscriber: thakis.
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 1:15 PM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
spupyrev mentioned this in D153039: [BOLT] A new code layout algorithm for function reordering [3b/3].Jul 31 2023, 1:15 PM
Harbormaster completed remote builds in B249298: Diff 545775.Jul 31 2023, 1:35 PM
Amir accepted this revision.Jul 31 2023, 1:46 PM
This revision is now accepted and ready to land.Jul 31 2023, 1:46 PM
Closed by commit rG299ec3c22a3b: [BOLT] Fixing macOS build (authored by spupyrev). · Explain WhyJul 31 2023, 1:56 PM
This revision was automatically updated to reflect the committed changes.
spupyrev added a commit: rG299ec3c22a3b: [BOLT] Fixing macOS build.

Revision Contents

PathSize
bolt/
lib/
Passes/
3 lines

Diff 545797

bolt/lib/Passes/ReorderFunctions.cpp

Show First 20 Lines • Show All 334 Lines • ▼ Show 20 Lines for (NodeId F = 0; F < Cg.numNodes(); ++F) {
} }
} }
// Run the layout algorithm. // Run the layout algorithm.
std::vector<uint64_t> Result = std::vector<uint64_t> Result =
applyCDSLayout(FuncSizes, FuncCounts, CallCounts, CallOffsets); applyCDSLayout(FuncSizes, FuncCounts, CallCounts, CallOffsets);
// Create a single cluster from the computed order of hot functions. // Create a single cluster from the computed order of hot functions.
Clusters.emplace_back(Cluster(Result, Cg)); std::vector<CallGraph::NodeId> NodeOrder(Result.begin(), Result.end());
Clusters.emplace_back(Cluster(NodeOrder, Cg));
} break; } break;
case RT_PETTIS_HANSEN: case RT_PETTIS_HANSEN:
Clusters = pettisAndHansen(Cg); Clusters = pettisAndHansen(Cg);
break; break;
case RT_RANDOM: case RT_RANDOM:
std::srand(opts::RandomSeed); std::srand(opts::RandomSeed);
Clusters = randomClusters(Cg); Clusters = randomClusters(Cg);
break; break;
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines