Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D156599

[profiling] Move option declarations into headers
ClosedPublic
Actions

Authored by tstellar on Jul 29 2023, 7:33 AM.

Details

Reviewers
bogner
dnovillo
hoy
huangjd
Commits
rGe7247f1010b5: [profiling] Move option declarations into headers
Summary

This will make it possible to add visibility attributes to these
variables. This also fixes some type mismatches between the
declaration and the definition.

Diff Detail

Event Timeline

tstellar created this revision.Jul 29 2023, 7:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2023, 7:33 AM
Herald added subscribers: wlei, Enna1, ormris and 2 others. · View Herald Transcript
tstellar requested review of this revision.Jul 29 2023, 7:33 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 29 2023, 7:33 AM
Herald added subscribers: llvm-commits, cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B249002: Diff 545375.Jul 29 2023, 10:12 AM
bogner accepted this revision.Jul 31 2023, 4:09 PM
This revision is now accepted and ready to land.Jul 31 2023, 4:09 PM
huangjd accepted this revision.Sep 14 2023, 2:55 PM
This revision was landed with ongoing or failed builds.Sep 30 2023, 6:52 PM
Closed by commit rGe7247f1010b5: [profiling] Move option declarations into headers (authored by tstellar). · Explain Why
This revision was automatically updated to reflect the committed changes.
tstellar added a commit: rGe7247f1010b5: [profiling] Move option declarations into headers.

Revision Contents
Changeset List

PathSize
clang/
lib/
CodeGen/
2 lines
llvm/
include/
llvm/
ProfileData/
8 lines
Transforms/
IPO/
8 lines
Instrumentation/
3 lines
lib/
Analysis/
10 lines
Transforms/
Instrumentation/
1 line
1 line
tools/
llvm-profgen/
8 lines

Diff 557514

View Options

clang/lib/CodeGen/BackendUtil.cpp

Loading...
View Options

llvm/include/llvm/ProfileData/ProfileCommon.h

Loading...
View Options

llvm/include/llvm/Transforms/IPO/SampleProfile.h

Loading...
View Options

llvm/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h

Loading...
View Options

llvm/lib/Analysis/ProfileSummaryInfo.cpp

Loading...
View Options

llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp

Loading...
View Options

llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp

Loading...
View Options

llvm/tools/llvm-profgen/CSPreInliner.cpp

Loading...