Page MenuHomePhabricator

dnovillo (Diego Novillo)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2013, 4:37 PM (331 w, 6 d)

Recent Activity

Jul 11 2019

dnovillo committed rGa35a7d49e5e9: Fix build errors LLVM tests are disabled. (authored by dnovillo).
Fix build errors LLVM tests are disabled.
Jul 11 2019, 3:10 PM
dnovillo committed rL365836: Fix build errors LLVM tests are disabled..
Fix build errors LLVM tests are disabled.
Jul 11 2019, 3:08 PM
dnovillo closed D63097: [cmake] Don't add Support/Testing library if tests are not included.
Jul 11 2019, 3:08 PM · Restricted Project
dnovillo added a comment to D63097: [cmake] Don't add Support/Testing library if tests are not included.

I'm currently testing this patch. Will be committing after all tests are done.

Jul 11 2019, 1:42 PM · Restricted Project

Jun 25 2019

dnovillo committed rL364342: Update phis in AMDGPUUnifyDivergentExitNodes.
Update phis in AMDGPUUnifyDivergentExitNodes
Jun 25 2019, 11:57 AM
dnovillo committed rG688afeb88448: Update phis in AMDGPUUnifyDivergentExitNodes (authored by dnovillo).
Update phis in AMDGPUUnifyDivergentExitNodes
Jun 25 2019, 11:56 AM

Mar 5 2019

dnovillo added inline comments to D57737: [AMDGPU] Fix DPP sequence in atomic optimizer..
Mar 5 2019, 5:21 AM · Restricted Project, Restricted Project

Oct 3 2018

dnovillo removed a reviewer for D52845: Update entry count for cold calls: dnovillo.
Oct 3 2018, 2:05 PM

May 11 2017

dnovillo accepted D33111: Change sample profile writer to make it deterministic..

LGTM. Thanks.

May 11 2017, 4:35 PM

Apr 26 2017

dnovillo accepted D32516: [sampleprof] Drop test dependency on the string hash func (NFC).
Apr 26 2017, 8:51 AM
dnovillo added a comment to D32516: [sampleprof] Drop test dependency on the string hash func (NFC).

Oh, so DAG vs DAG-NEXT, right?

Apr 26 2017, 8:51 AM
dnovillo accepted D32516: [sampleprof] Drop test dependency on the string hash func (NFC).

LGTM. Thanks.

Apr 26 2017, 6:43 AM

Feb 14 2017

dnovillo committed rL295065: Remove unused variable..
Remove unused variable.
Feb 14 2017, 8:51 AM

Dec 14 2016

dnovillo accepted D27743: Create SampleProfileLoader pass in llvm instead of clang.

LGTM

Dec 14 2016, 7:10 AM
dnovillo accepted D27744: Create SampleProfileLoader pass in llvm instead of clang.

LGTM

Dec 14 2016, 7:08 AM

Oct 7 2016

dnovillo accepted D25133: Update clang test to accomendate discriminator change in https://reviews.llvm.org/D25132.

LGTM

Oct 7 2016, 7:56 AM
dnovillo accepted D25132: Invoke add-discriminator at -g0 -fsample-profile.

Thanks, Dehao. This LGTM now. I'm not 100% sure about the code paths in *Dwarf*.cpp, but they look safe enough. The only concern there would be any other code that also calls getDiscriminator, in which case, perhaps we could sink the DWARF version check into getDiscriminator and have getDiscriminator return ErrorOr.

Oct 7 2016, 7:15 AM

Oct 3 2016

dnovillo added a comment to D25132: Invoke add-discriminator at -g0 -fsample-profile.

Another option would be: make SampleProfileFile option global, and checks if that option is empty here to decide if discriminator pass is needed.

Oct 3 2016, 8:27 AM
dnovillo added inline comments to D25132: Invoke add-discriminator at -g0 -fsample-profile.
Oct 3 2016, 7:00 AM

Sep 21 2016

dnovillo accepted D24788: Change the basic block weight calculation algorithm to use max instead of voting..

LGTM

Sep 21 2016, 8:23 AM

Sep 19 2016

dnovillo accepted D24734: Handle early inline for hot callsites that reside in the same basic block..

LGTM.

Sep 19 2016, 11:28 AM
dnovillo accepted D24732: Only set branch weight during sample pgo annotation when max_weight of the branch is non-zero. Otherwise use default static profile to set branch probability..

LGTM.

Sep 19 2016, 9:41 AM
dnovillo accepted D24730: Remove InstructionCombining and its related pass from sample pgo passes as we can handle "invoke" correctly..

LGTM. Thanks.

Sep 19 2016, 9:07 AM
dnovillo accepted D24410: Use call target count to derive the call instruction weight.
Sep 19 2016, 9:01 AM

Sep 18 2016

dnovillo added a comment to D24410: Use call target count to derive the call instruction weight.

OK, so instead of looking at the number of samples collected at the call site, it looks at the number of calls the target had. But what if the target is called disproportionately more from one call site than the other?

Sep 18 2016, 1:45 PM
dnovillo accepted D24409: Handle Invoke during sample profiler annotation: make it inlinable..

Apologies for the delay.

Sep 18 2016, 1:39 PM

Aug 26 2016

dnovillo added a comment to D23284: Add -fdiagnostics-show-hotness.

@dnovillo or @rsmith, can you please confirm if you agree that this new option -Rpass-with-hotness should not be part of R_group. R_group options enable/disable groups of remarks whereas this one is only modifying the text of the remarks. Thanks!

Aug 26 2016, 9:35 AM

Aug 12 2016

dnovillo accepted D23224: Fine tuning of sample profile propagation algorithm..

Thanks! LGTM.

Aug 12 2016, 6:53 AM

Aug 11 2016

dnovillo added a comment to D23224: Fine tuning of sample profile propagation algorithm..

Apologies for the delay, Dehao. Thanks for the description. That needs to be added to the code, so we have it for future reference. I suspect that several of the spots where I was confused and asked for comments are going to be good candidates to sprinkle that high-level description around.

Aug 11 2016, 2:16 PM

Aug 8 2016

dnovillo added a comment to D23224: Fine tuning of sample profile propagation algorithm..

Could you describe this in *much* more detail?

Aug 8 2016, 8:41 AM

Aug 5 2016

dnovillo accepted D23212: Do not assign new discriminator for all intrinsics..

LGTM

Aug 5 2016, 11:00 AM
dnovillo accepted D23082: [AutoFDO] Fix handling of empty profiles.
Aug 5 2016, 10:07 AM
dnovillo added a comment to D23082: [AutoFDO] Fix handling of empty profiles.

Adding Dehao. ISTR something special about 0 counts in profiles, but I don't recall details. Dehao, this looks fine to me, but will it break anything for samplepgo?

Aug 5 2016, 9:46 AM
dnovillo added a reviewer for D23082: [AutoFDO] Fix handling of empty profiles: danielcdh.
Aug 5 2016, 9:46 AM

Jul 19 2016

dnovillo added a comment to D22414: [BranchProbabilityInfo] Change analysis result storage to simplify basic block removal.

Any changes in build time? I guess I'm surprised that removal operations are more frequent than lookups.

Jul 19 2016, 5:21 AM

Jul 11 2016

dnovillo accepted D22228: Fix the assertion failure caused by http://reviews.llvm.org/D22118.

LGTM.

Jul 11 2016, 10:42 AM
dnovillo accepted D22118: Implement callsite-hotness based inline cost for Sample-based PGO.

LGTM with a couple of small changes.

Jul 11 2016, 7:48 AM
dnovillo accepted D22180: Tune the weight propagation algorithm for sample profile..

LGTM. Thanks.

Jul 11 2016, 6:27 AM

Jun 27 2016

dnovillo accepted D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else..

LGTM

Jun 27 2016, 5:26 AM

Jun 23 2016

dnovillo accepted D21568: Invoke simplifycfg and sroa before instcombine..

LGTM. Thanks for the testcase and description.

Jun 23 2016, 1:04 PM

Jun 22 2016

dnovillo added inline comments to D21568: Invoke simplifycfg and sroa before instcombine..
Jun 22 2016, 4:55 AM

Jun 21 2016

dnovillo accepted D21197: Invoke PruneEH pass before Sample Profile pass..

LGTM. Thanks!

Jun 21 2016, 12:21 PM

Jun 15 2016

dnovillo accepted D20957: [JumpThreading] Prevent dangling pointer problems in BranchProbabilityInfo.

Thanks for the test case.

Jun 15 2016, 1:33 PM

Jun 9 2016

dnovillo added a comment to D21197: Invoke PruneEH pass before Sample Profile pass..

A small test case, perhaps?

Jun 9 2016, 3:47 PM
dnovillo requested changes to D20957: [JumpThreading] Prevent dangling pointer problems in BranchProbabilityInfo.

I agree with Igor's analysis. Let's first fix the correctness issue. Any compile-time problems that show up, can be fixed with a data structure change later. Igor, do you have any test cases that show the problem? Without a test case, it's harder to justify this change.

Jun 9 2016, 3:45 PM

May 24 2016

dnovillo accepted D20530: Proposal for using stricter error checking in SampleProf.

Sounds like a great plan. Thanks for doing this!

May 24 2016, 7:38 AM
dnovillo accepted D20501: Remove sample profile dependency to instcombine, which is not a analysis pass..

Now, if the sample profiler depends on instcombine, we'd have to schedule it after instcombine, right?

May 24 2016, 6:34 AM
dnovillo accepted D20502: Add instcombine pass if sampleprofile pass is enabled..

Ah. I should'be read this one first :) Ignore my question on http://reviews.llvm.org/D17742, then.

May 24 2016, 6:33 AM
dnovillo added a comment to D20501: Remove sample profile dependency to instcombine, which is not a analysis pass..

Now, if the sample profiler depends on instcombine, we'd have to schedule it after instcombine, right?

May 24 2016, 6:32 AM

May 5 2016

dnovillo accepted D19926: Simplify CFG before assigning discriminator..
May 5 2016, 9:26 AM
dnovillo added a comment to D19926: Simplify CFG before assigning discriminator..

OK, sure. What I meant is a testcase that motivates this change.

May 5 2016, 9:12 AM
dnovillo added a comment to D19926: Simplify CFG before assigning discriminator..

Would it be possible to get a test case where we miss discriminator placement if simplifycfg doesn't run beforehand?

May 5 2016, 5:16 AM

Apr 29 2016

dnovillo added a comment to D19704: Do not read callee name when matching IR to profile as it is not used..

Cool, thanks.

Apr 29 2016, 8:01 AM
dnovillo accepted D19704: Do not read callee name when matching IR to profile as it is not used..

I was going to ask about a test case, but we already have test cases that cover this, right?

Apr 29 2016, 5:47 AM

Apr 25 2016

dnovillo accepted D19301: Tune basic block annotation algorithm..

LGTM. Apologies for the delay.

Apr 25 2016, 6:33 AM

Apr 20 2016

dnovillo added a comment to D19049: [BlockFrequencyInfo] Handling nested irreducible CFG with geometric series and top-down prorogation.

I have started going over this patch, but my knowledge of this area is pretty spotty. I defer to Duncan for a better opinion on this.

Apr 20 2016, 11:38 AM
dnovillo added a comment to D19287: Remove inline hints computation from SampleProfile.cpp.

This looks fine, but let's wait until Easwaran's inliner support lands before submitting this change.

Apr 20 2016, 11:37 AM

Apr 14 2016

dnovillo accepted D19127: Update discriminator assignment algorithm to handle nested call correctly..

Looks much simpler. Thanks!

Apr 14 2016, 11:28 AM

Mar 28 2016

dnovillo accepted D18522: Sample profile summary cleanup.

Nothing here seems to change the format of the external file, but could you double check with the AutoFDO converter that we can still read Perf profiles?

Mar 28 2016, 12:42 PM
dnovillo accepted D18468: Profile summary cleanup..

LGTM

Mar 28 2016, 9:19 AM
dnovillo added a reviewer for D18468: Profile summary cleanup.: danielcdh.
Mar 28 2016, 9:19 AM
dnovillo added a comment to D18468: Profile summary cleanup..

Is there a way to exclude header sample from the body samples?

Mar 28 2016, 9:16 AM

Mar 10 2016

dnovillo added a comment to D17894: Interface to get/set profile summary metadata to module.

Needs a test. Otherwise, LGTM. Thanks.

Mar 10 2016, 10:02 AM

Mar 2 2016

dnovillo accepted D17827: Use LineLocation instead of CallsiteLocation to index callsite profile..

Just to make sure AutoFDO is still working, would you mind building it with your LLVM build to make sure that create_llvm_prof still works?

Mar 2 2016, 3:32 PM
dnovillo added a comment to D17827: Use LineLocation instead of CallsiteLocation to index callsite profile..

Nice cleanup! I think we can prevent breaking the AutoFDO tool by adding an overload.

Mar 2 2016, 2:36 PM

Mar 1 2016

dnovillo accepted D17742: Perform InstructioinCombiningPass before SampleProfile pass..
Mar 1 2016, 2:36 PM
dnovillo added a comment to D17742: Perform InstructioinCombiningPass before SampleProfile pass..

Could you give me a bit more context? A C/C++ motivating example would be great. I think I follow what the intent is, but I'd like to make sure and leave it documented in the commit log.

Mar 1 2016, 6:17 AM

Feb 29 2016

dnovillo accepted D17664: Move discriminator assignment to the right place..

LGTM. Thanks for the fix!

Feb 29 2016, 10:38 AM

Feb 26 2016

dnovillo accepted D17624: Metadata support for profile summary.

Looks fine to me, though I'm not an expert on MD.

Feb 26 2016, 12:11 PM

Feb 22 2016

dnovillo accepted D17522: Set function entry count as 0 if sample profile is not found for the function..

LGTM.

Feb 22 2016, 2:41 PM

Feb 18 2016

dnovillo accepted D17178: Add profile summary support for sample profile.

Thanks for the new feature! LGTM with one minor nit.

Feb 18 2016, 9:52 AM

Feb 17 2016

dnovillo requested changes to D17178: Add profile summary support for sample profile.
Feb 17 2016, 6:14 AM

Feb 16 2016

dnovillo added a comment to D17178: Add profile summary support for sample profile.

I just started looking at this. Some early feedback so we can discuss whether my idea makes sense. Mostly, I'm thinking we want to support summary data in text profiles for testing and debugging. Does that make sense to you?

Feb 16 2016, 11:20 AM

Dec 17 2015

dnovillo committed rL255897: Fix unused variable warning in release builds. NFC..
Fix unused variable warning in release builds. NFC.
Dec 17 2015, 7:01 AM

Dec 16 2015

dnovillo committed rL255809: Add -fsyntax-only to fix failure in read-only directories..
Add -fsyntax-only to fix failure in read-only directories.
Dec 16 2015, 11:55 AM

Dec 14 2015

dnovillo added inline comments to D14888: Indirect call optimization.
Dec 14 2015, 2:14 PM
dnovillo added a comment to D15503: [PGO] Shorten profile symbol prefixes.

Nice. Thanks. The shortened names are indeed easier to read (in addition to the size savings).

Dec 14 2015, 1:05 PM
dnovillo added a comment to D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

I like the new way of specifying weighted input better. Thanks! This LGTM with a couple of changes below.

Dec 14 2015, 12:52 PM
dnovillo committed rL255541: Fix formatting. NFC..
Fix formatting. NFC.
Dec 14 2015, 12:40 PM

Dec 11 2015

dnovillo committed rL255389: SamplePGO - Reduce memory utilization by 10x..
SamplePGO - Reduce memory utilization by 10x.
Dec 11 2015, 3:24 PM

Dec 8 2015

dnovillo added a comment to D15124: Use @llvm.invariant.start/end intrinsics to extend basic AA with invariant range analysis for GVN-based load elimination purposes [Local objects only].
Dec 8 2015, 2:38 PM

Dec 7 2015

dnovillo added a comment to D15245: Use the inlinehint-threshold for hot callees..

Once this is in, please update lib/Transforms/IPO/SampleProfile.cpp. It does something similar.

Dec 7 2015, 10:53 AM

Dec 4 2015

dnovillo added a comment to D15124: Use @llvm.invariant.start/end intrinsics to extend basic AA with invariant range analysis for GVN-based load elimination purposes [Local objects only].

I've just started looking at this, so these first few comments are mostly for my benefit to make sure I'm understanding this.

Dec 4 2015, 11:14 AM
dnovillo added a reviewer for D15124: Use @llvm.invariant.start/end intrinsics to extend basic AA with invariant range analysis for GVN-based load elimination purposes [Local objects only]: dnovillo.
Dec 4 2015, 9:42 AM

Nov 29 2015

dnovillo committed rL254261: SamplePGO - Do not use std::to_string in diagnostics..
SamplePGO - Do not use std::to_string in diagnostics.
Nov 29 2015, 10:26 AM

Nov 27 2015

dnovillo committed rL254212: SamplePGO - Add initial support for inliner annotations..
SamplePGO - Add initial support for inliner annotations.
Nov 27 2015, 3:17 PM
dnovillo committed rL254211: SamplePGO - Fix default threshold for hot callsites..
SamplePGO - Fix default threshold for hot callsites.
Nov 27 2015, 3:17 PM

Nov 26 2015

dnovillo added a comment to D15003: Interface to attach maximum function count from PGO to module as module flags..

How is this going to interact with SamplePGO? Currently, I'm testing a change that adds the InlineHint attribute for functions that globally collected a fraction of samples greater than a given threshold. Likewise, for functions that fall below another threshold, they receive the Cold attribute.

Nov 26 2015, 1:34 PM

Nov 24 2015

dnovillo committed rL254034: SamplePGO - Add test for hot/cold inlined functions..
SamplePGO - Add test for hot/cold inlined functions.
Nov 24 2015, 2:41 PM

Nov 23 2015

dnovillo committed rL253912: SamplePGO - Add coverage tracking for samples..
SamplePGO - Add coverage tracking for samples.
Nov 23 2015, 12:15 PM
dnovillo committed rL253877: SamplePGO - Clear coverage tracking when clearing per-function data..
SamplePGO - Clear coverage tracking when clearing per-function data.
Nov 23 2015, 8:33 AM
dnovillo committed rL253868: SamplePGO - Use newly introduced local variable. NFC..
SamplePGO - Use newly introduced local variable. NFC.
Nov 23 2015, 7:27 AM
dnovillo added inline comments to D14894: [PGO] Add --text-format option for llvm-profdata show|merge commands.
Nov 23 2015, 6:53 AM

Nov 20 2015

dnovillo committed rL253717: SamplePGO - Tweak RUN command for a test. NFC..
SamplePGO - Tweak RUN command for a test. NFC.
Nov 20 2015, 1:49 PM
dnovillo committed rL253716: SamplePGO - Do not count never-executed inlined functions when computing….
SamplePGO - Do not count never-executed inlined functions when computing…
Nov 20 2015, 1:49 PM
dnovillo committed rL253670: SamplePGO - Add line offset and discriminator information to sample reports..
SamplePGO - Add line offset and discriminator information to sample reports.
Nov 20 2015, 7:42 AM

Nov 19 2015

dnovillo committed rL253612: SamplePGO - Tweak debugging output for function samples. NFC..
SamplePGO - Tweak debugging output for function samples. NFC.
Nov 19 2015, 2:21 PM
dnovillo accepted D14836: Update clang tests to accomendate discriminator changes..

LGTM. Thanks.

Nov 19 2015, 11:32 AM
dnovillo committed rL253568: SamplePGO - Sort samples by source location when emitting as text..
SamplePGO - Sort samples by source location when emitting as text.
Nov 19 2015, 7:35 AM
dnovillo added a comment to D14720: [llvm-profdata] Add SaturatingAdd/SaturatingMultiply Helper Functions.

Related question:

Is it by design that intstr profile count overflow is treated differently from sample profile count overflow?
Instr profile merging appears to skip records that would result in overflow and print a warning. Sample profile count overflow saturates and does not show a warning.

Nov 19 2015, 5:03 AM