This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Add shifts to constant_fold combine
ClosedPublic

Authored by arsenm on Jul 28 2023, 6:36 AM.

Details

Summary

Currently we're getting away with post-selection constant folding on
these (a hack which exists for the DAG).

Diff Detail

Unit TestsFailed

Event Timeline

arsenm created this revision.Jul 28 2023, 6:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2023, 6:36 AM
arsenm requested review of this revision.Jul 28 2023, 6:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2023, 6:36 AM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm updated this revision to Diff 545165.Jul 28 2023, 7:45 AM

Vector tests, don't fold yet

Pierre-vh accepted this revision.Aug 24 2023, 4:35 AM

LGTM, don't forget to rebase & rerun tests in case there's more updates needed following MIR patterns landing :)

This revision is now accepted and ready to land.Aug 24 2023, 4:35 AM