This is an archive of the discontinued LLVM Phabricator instance.

Differential D156500

[RISCV] Fix typo in C9LeftShift
ClosedPublic

Authored by wangpc on Jul 27 2023, 8:38 PM.

Details

Reviewers
craig.topper
kazu
Commits
rG19a1b67b6d7a: [RISCV] Fix typo in C9LeftShift
Summary

It should be 9 instead of 5.

Diff Detail

Event Timeline

wangpc created this revision.Jul 27 2023, 8:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 8:38 PM
Herald added subscribers: jobnoorman, luke, VincentWu and 28 others. · View Herald Transcript
wangpc requested review of this revision.Jul 27 2023, 8:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 8:38 PM
Herald added subscribers: llvm-commits, eopXD, MaskRay. · View Herald Transcript
wangpc added a reviewer: kazu.Jul 27 2023, 8:39 PM
Harbormaster completed remote builds in B248745: Diff 545010.Jul 27 2023, 9:43 PM
kazu accepted this revision.Jul 30 2023, 4:55 PM

Thanks!

This revision is now accepted and ready to land.Jul 30 2023, 4:55 PM
wangpc edited the summary of this revision. (Show Details)Jul 31 2023, 1:34 AM
Closed by commit rG19a1b67b6d7a: [RISCV] Fix typo in C9LeftShift (authored by wangpc). · Explain WhyJul 31 2023, 1:50 AM
This revision was automatically updated to reflect the committed changes.
wangpc added a commit: rG19a1b67b6d7a: [RISCV] Fix typo in C9LeftShift.

Revision Contents

PathSize
llvm/
lib/
Target/
RISCV/
2 lines

Diff 545539

llvm/lib/Target/RISCV/RISCVInstrInfoZb.td

Show First 20 Lines • Show All 177 Lines • ▼ Show 20 Lines
def C5LeftShift : PatLeaf<(imm), [{ def C5LeftShift : PatLeaf<(imm), [{
uint64_t C = N->getZExtValue(); uint64_t C = N->getZExtValue();
return C > 5 && (C >> llvm::countr_zero(C)) == 5; return C > 5 && (C >> llvm::countr_zero(C)) == 5;
}]>; }]>;
def C9LeftShift : PatLeaf<(imm), [{ def C9LeftShift : PatLeaf<(imm), [{
uint64_t C = N->getZExtValue(); uint64_t C = N->getZExtValue();
return C > 5 && (C >> llvm::countr_zero(C)) == 9; return C > 9 && (C >> llvm::countr_zero(C)) == 9;
}]>; }]>;
// Constant of the form (3 << C) where C is less than 32. // Constant of the form (3 << C) where C is less than 32.
def C3LeftShiftUW : PatLeaf<(imm), [{ def C3LeftShiftUW : PatLeaf<(imm), [{
uint64_t C = N->getZExtValue(); uint64_t C = N->getZExtValue();
unsigned Shift = llvm::countr_zero(C); unsigned Shift = llvm::countr_zero(C);
return 1 <= Shift && Shift < 32 && (C >> Shift) == 3; return 1 <= Shift && Shift < 32 && (C >> Shift) == 3;
}]>; }]>;
▲ Show 20 Lines • Show All 607 Lines • Show Last 20 Lines