This is an archive of the discontinued LLVM Phabricator instance.

[NFC][clang] Fix static analyzer concerns
ClosedPublic

Authored by Fznamznon on Jul 27 2023, 2:49 AM.

Details

Summary

IdentifierResolver frees resources in the destructor but doesn't
have user-written copy c'tor or assignment operator, so copying it using
default ones can cause double free.

Diff Detail

Event Timeline

Fznamznon created this revision.Jul 27 2023, 2:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 2:49 AM
Fznamznon requested review of this revision.Jul 27 2023, 2:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 2:49 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision is now accepted and ready to land.Jul 27 2023, 4:17 AM
Fznamznon updated this revision to Diff 545080.Jul 28 2023, 2:41 AM

Rebase to maybe pass precommit

The failures are unrelated.

This revision was landed with ongoing or failed builds.Jul 28 2023, 5:35 AM
This revision was automatically updated to reflect the committed changes.