This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Correct policy operand for RVV ISel patterns with merge operand as implicit_def (NFC)
ClosedPublic

Authored by eopXD on Jul 26 2023, 9:23 AM.

Details

Summary

The trailing TU_MU suffixes was added in D154625. The trailing policy
operand for these patterns has no real affect, as the vsetvli insertion
pass omits the trailing policy operand when the merge operand is
undefined.

This patch is essentially an NFC. However, the policy implied for these
patterns is actually TA_MA. This patch corrects them to avoid confusion.

Diff Detail

Event Timeline

eopXD created this revision.Jul 26 2023, 9:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2023, 9:23 AM
eopXD requested review of this revision.Jul 26 2023, 9:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2023, 9:23 AM
eopXD edited the summary of this revision. (Show Details)Jul 26 2023, 9:24 AM

The policy field is ignored if the merge op is implicit_def. That's why there are no test cahnges.

This revision is now accepted and ready to land.Jul 26 2023, 9:30 AM

(Is the differential link in description the right one?)

eopXD edited the summary of this revision. (Show Details)Jul 26 2023, 9:51 PM

(Is the differential link in description the right one?)

Thank you for noticing, just updated the description.

eopXD retitled this revision from [RISCV] Improve policy emission for RVV pseudo instructions to [RISCV] Correct policy operand for RVV ISel patterns with merge operand as implicit_def (NFC).Jul 26 2023, 10:09 PM
eopXD edited the summary of this revision. (Show Details)

With further investigation and Craig's guidance. I now see that this patch is an NFC.

This revision was landed with ongoing or failed builds.Jul 26 2023, 10:17 PM
This revision was automatically updated to reflect the committed changes.