This is an archive of the discontinued LLVM Phabricator instance.

Differential D156252

[mlir][GPU] Fix missing CMake dependency
ClosedPublic

Authored by qedawkins on Jul 25 2023, 10:48 AM.

Download Raw Diff

Details

Reviewers

bondhugula
ThomasRaoux
nicolasvasilache
herhut
mehdi_amini

Commits

rG24567dd4ba2c: [mlir][GPU] Fix missing CMake dependency

Summary

Fixes buildbot failure from D156079

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

qedawkins created this revision.Jul 25 2023, 10:48 AM

Herald added a reviewer: bondhugula. · View Herald TranscriptJul 25 2023, 10:48 AM

Herald added a reviewer: ThomasRaoux. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: bviyer, Moerafaat, zero9178 and 22 others. · View Herald Transcript

qedawkins requested review of this revision.Jul 25 2023, 10:48 AM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptJul 25 2023, 10:48 AM

Herald added a reviewer: herhut. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

qedawkins added a reviewer: mehdi_amini.Jul 25 2023, 10:48 AM

You don't need code review when you fix a buildbot with a trivial patch: we favor "time to get back to green", please land ASAP.

This revision is now accepted and ready to land.Jul 25 2023, 11:26 AM

This revision was landed with ongoing or failed builds.Jul 25 2023, 11:28 AM

Closed by commit rG24567dd4ba2c: [mlir][GPU] Fix missing CMake dependency (authored by qedawkins). · Explain Why

This revision was automatically updated to reflect the committed changes.

qedawkins added a commit: rG24567dd4ba2c: [mlir][GPU] Fix missing CMake dependency.

In D156252#4532781, @mehdi_amini wrote:

You don't need code review when you fix a buildbot with a trivial patch: we favor "time to get back to green", please land ASAP.

I was just reading through the developer policy for that. Apologies again.

Harbormaster completed remote builds in B248038: Diff 544040.Jul 25 2023, 7:06 PM

Revision Contents

Path

Size

mlir/

lib/

Dialect/

GPU/

TransformOps/

1 line

Diff 544052

mlir/lib/Dialect/GPU/TransformOps/CMakeLists.txt

	Show All 13 Lines		add_mlir_dialect_library(MLIRGPUTransformOps
	LINK_LIBS PUBLIC			LINK_LIBS PUBLIC
	MLIRGPUDialect			MLIRGPUDialect
	MLIRGPUTransforms			MLIRGPUTransforms
	MLIRIR			MLIRIR
	MLIRParser			MLIRParser
	MLIRSideEffectInterfaces			MLIRSideEffectInterfaces
	MLIRTransformDialect			MLIRTransformDialect
	MLIRVectorDialect			MLIRVectorDialect
				MLIRVectorTransforms
	)			)