This is an archive of the discontinued LLVM Phabricator instance.

[X86] Support -march=arrowlake,arrowlake-s,lunarlake
ClosedPublic

Authored by FreddyYe on Jul 25 2023, 7:14 AM.

Diff Detail

Event Timeline

FreddyYe created this revision.Jul 25 2023, 7:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2023, 7:14 AM
FreddyYe requested review of this revision.Jul 25 2023, 7:14 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptJul 25 2023, 7:14 AM
Herald added subscribers: llvm-commits, Restricted Project, cfe-commits. · View Herald Transcript
RKSimon added inline comments.Jul 25 2023, 7:43 AM
clang/test/Preprocessor/predefined-arch-macros.c
2574

Do the CHECK_SRF_M64-NOT trick to make sure AVXVNNIINT16 isn't defined without CHECK_ARLS_M64?

FreddyYe updated this revision to Diff 544159.Jul 25 2023, 5:31 PM
FreddyYe marked an inline comment as done.

Address comment.

RKSimon added inline comments.Jul 26 2023, 3:32 AM
llvm/test/CodeGen/X86/cpus-intel.ll
37

duplicate?

99

duplicate?

FreddyYe marked 2 inline comments as done.Jul 26 2023, 4:09 AM
FreddyYe added inline comments.
llvm/test/CodeGen/X86/cpus-intel.ll
37

No, it is - vs _

99

Same above.

RKSimon added inline comments.Jul 26 2023, 4:26 AM
llvm/test/CodeGen/X86/cpus-intel.ll
37

Got it - does that mean we should have added "graniterapids_d" as well?

FreddyYe marked 3 inline comments as done.Jul 26 2023, 4:42 AM
FreddyYe added inline comments.
llvm/test/CodeGen/X86/cpus-intel.ll
37

Right! I realized that's a missing when I added here. But it may introduce conflict here so I prefer to add it in later patch.

RKSimon added inline comments.Jul 26 2023, 4:51 AM
llvm/lib/TargetParser/X86TargetParser.cpp
430

CK_ArrowlakeS?

FreddyYe updated this revision to Diff 544314.Jul 26 2023, 5:01 AM
FreddyYe marked 2 inline comments as done.

address comment.

pengfei accepted this revision.Jul 26 2023, 11:28 PM

LGTM.

llvm/lib/Target/X86/X86.td
1730

Merge "lunarlake" here?

This revision is now accepted and ready to land.Jul 26 2023, 11:28 PM
FreddyYe updated this revision to Diff 544625.Jul 27 2023, 12:01 AM
FreddyYe marked an inline comment as done.

address comment.

This revision was landed with ongoing or failed builds.Jul 28 2023, 12:06 AM
This revision was automatically updated to reflect the committed changes.