Details
Details
- Reviewers
ldionne - Group Reviewers
Restricted Project - Commits
- rG3c28ce6bec76: [libc++] Adds __throw_system_error overload.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
libcxx/src/system_error.cpp | ||
---|---|---|
279 | I think we should try to avoid adding this to the dylib, since otherwise we need to introduce a new availability macro just for this function. I would just define it in the headers. |
Comment Actions
It looks like this change is a likely root cause for a size regression on Fuchsia. In particular, Fuchsia maintains a hermetic -fno-exceptions multilib of libc++.a that is statically linked into other binaries/libraries. Previously, the no-exceptions version of this code didn't depend on the error code or category libraries, but this change seems to bring them into the link unnecessarily. Would it be possible to revert this or to fix it forward to keep the no-exception case separate from these routines?
I think we should try to avoid adding this to the dylib, since otherwise we need to introduce a new availability macro just for this function. I would just define it in the headers.