This is an archive of the discontinued LLVM Phabricator instance.

Differential D155931

[flang][nfc] Clarify the usage of llvmArgs and mlirArgs
ClosedPublic

Authored by awarzynski on Jul 21 2023, 2:50 AM.

Details

Reviewers
kiranchandramohan
DavidTruby
kkwli0
Commits
rGebc2c71d63b6: [flang][nfc] Clarify the usage of llvmArgs and mlirArgs

Diff Detail

Event Timeline

awarzynski created this revision.Jul 21 2023, 2:50 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 21 2023, 2:50 AM
Herald added subscribers: sunshaoce, bzcheeseman, rriddle. · View Herald Transcript
awarzynski requested review of this revision.Jul 21 2023, 2:50 AM
Herald added subscribers: stephenneuendorffer, jdoerfert. · View Herald TranscriptJul 21 2023, 2:50 AM
awarzynski mentioned this in D155852: [flang] Add -fppc-native-vector-element-order option to control the element order in PowerPC vector types.Jul 21 2023, 2:52 AM
kiranchandramohan accepted this revision.Jul 21 2023, 4:10 AM

LG.

This revision is now accepted and ready to land.Jul 21 2023, 4:10 AM
This revision was landed with ongoing or failed builds.Jul 21 2023, 8:24 AM
Closed by commit rGebc2c71d63b6: [flang][nfc] Clarify the usage of llvmArgs and mlirArgs (authored by awarzynski). · Explain Why
This revision was automatically updated to reflect the committed changes.
awarzynski added a commit: rGebc2c71d63b6: [flang][nfc] Clarify the usage of llvmArgs and mlirArgs.

Revision Contents

PathSize
flang/
lib/
Frontend/
7 lines

Diff 542934

flang/lib/Frontend/CompilerInvocation.cpp

Show First 20 Lines • Show All 944 Lines • ▼ Show 20 Linesbool CompilerInvocation::createFromArgs(
success &= parseFrontendArgs(res.getFrontendOpts(), args, diags); success &= parseFrontendArgs(res.getFrontendOpts(), args, diags);
parseTargetArgs(res.getTargetOpts(), args); parseTargetArgs(res.getTargetOpts(), args);
parsePreprocessorArgs(res.getPreprocessorOpts(), args); parsePreprocessorArgs(res.getPreprocessorOpts(), args);
parseCodeGenArgs(res.getCodeGenOpts(), args, diags); parseCodeGenArgs(res.getCodeGenOpts(), args, diags);
success &= parseDebugArgs(res.getCodeGenOpts(), args, diags); success &= parseDebugArgs(res.getCodeGenOpts(), args, diags);
success &= parseSemaArgs(res, args, diags); success &= parseSemaArgs(res, args, diags);
success &= parseDialectArgs(res, args, diags); success &= parseDialectArgs(res, args, diags);
success &= parseDiagArgs(res, args, diags); success &= parseDiagArgs(res, args, diags);
// Collect LLVM (-mllvm) and MLIR (-mmlir) options.
// NOTE: Try to avoid adding any options directly to `llvmArgs` or
// `mlirArgs`. Instead, you can use
// * `-mllvm <your-llvm-option>`, or
// * `-mmlir <your-mlir-option>`.
res.frontendOpts.llvmArgs = res.frontendOpts.llvmArgs =
args.getAllArgValues(clang::driver::options::OPT_mllvm); args.getAllArgValues(clang::driver::options::OPT_mllvm);
res.frontendOpts.mlirArgs = res.frontendOpts.mlirArgs =
args.getAllArgValues(clang::driver::options::OPT_mmlir); args.getAllArgValues(clang::driver::options::OPT_mmlir);
success &= parseFloatingPointArgs(res, args, diags); success &= parseFloatingPointArgs(res, args, diags);
// Set the string to be used as the return value of the COMPILER_OPTIONS // Set the string to be used as the return value of the COMPILER_OPTIONS
// intrinsic of iso_fortran_env. This is either passed in from the parent // intrinsic of iso_fortran_env. This is either passed in from the parent
// compiler driver invocation with an environment variable, or failing that // compiler driver invocation with an environment variable, or failing that
▲ Show 20 Lines • Show All 196 Lines • Show Last 20 Lines