This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Add flag to disable fdiv processing in IR pass
ClosedPublic

Authored by arsenm on Jul 19 2023, 5:55 AM.

Details

Reviewers
foad
rampitec
Pierre-vh
Group Reviewers
Restricted Project
Summary

We kind of have to have multiple implementations of fdiv split between
the two selectors with some pre-processing. Add yet another test to
check for consistency of interpretation of flag combinations. We have
quite a bit of test redundancy here already, but there are so many
possible interesting permutations it's unwieldy to cover every detail
in any one of them. We have a number of overlapping fdiv tests but
it's hard to follow everything going on as it is.

Diff Detail

Event Timeline

arsenm created this revision.Jul 19 2023, 5:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 5:55 AM
arsenm requested review of this revision.Jul 19 2023, 5:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 5:55 AM
Herald added a subscriber: wdng. · View Herald Transcript
Pierre-vh accepted this revision as: Pierre-vh.Jul 19 2023, 6:06 AM
This revision is now accepted and ready to land.Jul 19 2023, 6:06 AM
arsenm updated this revision to Diff 541982.Jul 19 2023, 6:11 AM