This is an archive of the discontinued LLVM Phabricator instance.

Differential D155558

[clangd][c++20] Add concept Hover tests.
ClosedPublic

Authored by massberg on Jul 18 2023, 12:51 AM.

Details

Reviewers
sammccall
Commits
rGe9ab43dd44ca: [clangd][c++20] Add concept Hover tests.
Summary

Concepts aren't fully supporteb by hover yet. For the currently
supported case we add a test here to prevent regressions in the future.

Diff Detail

Event Timeline

massberg created this revision.Jul 18 2023, 12:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 12:51 AM
Herald added subscribers: kadircet, arphaman. · View Herald Transcript
massberg requested review of this revision.Jul 18 2023, 12:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 12:51 AM
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. · View Herald Transcript
sammccall accepted this revision.Jul 18 2023, 1:03 AM
This revision is now accepted and ready to land.Jul 18 2023, 1:03 AM
This revision was landed with ongoing or failed builds.Jul 18 2023, 1:20 AM
Closed by commit rGe9ab43dd44ca: [clangd][c++20] Add concept Hover tests. (authored by massberg). · Explain Why
This revision was automatically updated to reflect the committed changes.
massberg added a commit: rGe9ab43dd44ca: [clangd][c++20] Add concept Hover tests..
Harbormaster completed remote builds in B246106: Diff 541370.Jul 18 2023, 4:25 AM

Revision Contents

PathSize
clang-tools-extra/
clangd/
unittests/
34 lines

Diff 541390

clang-tools-extra/clangd/unittests/HoverTests.cpp

Show First 20 Lines • Show All 517 Lines • ▼ Show 20 Linesclass Foo final {})cpp";
[[au^to]] x = Foo<int>(); [[au^to]] x = Foo<int>();
} }
)cpp", )cpp",
[](HoverInfo &HI) { [](HoverInfo &HI) {
HI.Name = "auto"; HI.Name = "auto";
HI.Kind = index::SymbolKind::TypeAlias; HI.Kind = index::SymbolKind::TypeAlias;
HI.Definition = "Foo<int>"; HI.Definition = "Foo<int>";
}}, }},
// constrained template parameter
{R"cpp(
template<class T> concept Fooable = true;
template<[[Foo^able]] T>
void bar(T t) {}
)cpp",
[](HoverInfo &HI) {
HI.NamespaceScope = "";
HI.Name = "Fooable";
HI.Kind = index::SymbolKind::Concept;
HI.Definition = "template <class T>\nconcept Fooable = true";
}},
{R"cpp(
template<class T> concept Fooable = true;
template<Fooable [[T^T]]>
void bar(TT t) {}
)cpp",
[](HoverInfo &HI) {
HI.Name = "TT";
HI.Type = "class";
HI.AccessSpecifier = "public";
HI.NamespaceScope = "";
HI.LocalScope = "bar::";
HI.Kind = index::SymbolKind::TemplateTypeParm;
HI.Definition = "Fooable TT";
}},
// empty macro // empty macro
{R"cpp( {R"cpp(
#define MACRO #define MACRO
[[MAC^RO]] [[MAC^RO]]
)cpp", )cpp",
[](HoverInfo &HI) { [](HoverInfo &HI) {
HI.Name = "MACRO"; HI.Name = "MACRO";
▲ Show 20 Lines • Show All 2,486 Lines • ▼ Show 20 Lines
} }
} }
TEST(Hover, Providers) { TEST(Hover, Providers) {
struct { struct {
const char *Code; const char *Code;
const std::function<void(HoverInfo &)> ExpectedBuilder; const std::function<void(HoverInfo &)> ExpectedBuilder;
} Cases[] = {{R"cpp( } Cases[] = {{R"cpp(
struct Foo {}; struct Foo {};
Foo F = Fo^o{}; Foo F = Fo^o{};
)cpp", )cpp",
[](HoverInfo &HI) { HI.Provider = ""; }}, [](HoverInfo &HI) { HI.Provider = ""; }},
{R"cpp( {R"cpp(
#include "foo.h" #include "foo.h"
Foo F = Fo^o{}; Foo F = Fo^o{};
)cpp", )cpp",
[](HoverInfo &HI) { HI.Provider = "\"foo.h\""; }}, [](HoverInfo &HI) { HI.Provider = "\"foo.h\""; }},
{R"cpp( {R"cpp(
#include "all.h" #include "all.h"
Foo F = Fo^o{}; Foo F = Fo^o{};
)cpp", )cpp",
[](HoverInfo &HI) { HI.Provider = "\"foo.h\""; }}, [](HoverInfo &HI) { HI.Provider = "\"foo.h\""; }},
{R"cpp( {R"cpp(
#define FOO 5 #define FOO 5
int F = ^FOO; int F = ^FOO;
)cpp", )cpp",
[](HoverInfo &HI) { HI.Provider = ""; }}, [](HoverInfo &HI) { HI.Provider = ""; }},
{R"cpp( {R"cpp(
#include "foo.h" #include "foo.h"
int F = ^FOO; int F = ^FOO;
)cpp", )cpp",
[](HoverInfo &HI) { HI.Provider = "\"foo.h\""; }}, [](HoverInfo &HI) { HI.Provider = "\"foo.h\""; }},
{R"cpp( {R"cpp(
#include "all.h" #include "all.h"
int F = ^FOO; int F = ^FOO;
)cpp", )cpp",
[](HoverInfo &HI) { HI.Provider = "\"foo.h\""; }}, [](HoverInfo &HI) { HI.Provider = "\"foo.h\""; }},
{R"cpp( {R"cpp(
#include "foo.h" #include "foo.h"
Foo A; Foo A;
Foo B; Foo B;
Foo C = A ^+ B; Foo C = A ^+ B;
)cpp", )cpp",
[](HoverInfo &HI) { HI.Provider = "\"foo.h\""; }}, [](HoverInfo &HI) { HI.Provider = "\"foo.h\""; }},
// Hover selects the underlying decl of the using decl // Hover selects the underlying decl of the using decl
{R"cpp( {R"cpp(
#include "foo.h" #include "foo.h"
▲ Show 20 Lines • Show All 1,066 Lines • Show Last 20 Lines