This is an archive of the discontinued LLVM Phabricator instance.

Differential D155474

[mlir][nvvm] Delete backslash
ClosedPublic

Authored by guraypp on Jul 17 2023, 8:39 AM.

Details

Reviewers
springerm
ftynse
bondhugula
dcaballe
nicolasvasilache
Commits
rGbaba13e9a19d: [mlir][nvvm] Delete backslash
Summary

Delete the backslash. It was there to compile tablegen file. It looks like space also works fine.

Diff Detail

Event Timeline

guraypp created this revision.Jul 17 2023, 8:39 AM
Herald added a reviewer: ftynse. · View Herald TranscriptJul 17 2023, 8:39 AM
Herald added a reviewer: bondhugula. · View Herald Transcript
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: gysit, Dinistro, bviyer and 26 others. · View Herald Transcript
guraypp requested review of this revision.Jul 17 2023, 8:39 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptJul 17 2023, 8:39 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache, jholewinski. · View Herald Transcript
springerm accepted this revision.Jul 17 2023, 8:39 AM
This revision is now accepted and ready to land.Jul 17 2023, 8:39 AM
This revision was landed with ongoing or failed builds.Jul 17 2023, 8:57 AM
Closed by commit rGbaba13e9a19d: [mlir][nvvm] Delete backslash (authored by guraypp). · Explain Why
This revision was automatically updated to reflect the committed changes.
guraypp added a commit: rGbaba13e9a19d: [mlir][nvvm] Delete backslash.
Harbormaster completed remote builds in B245875: Diff 541062.Jul 17 2023, 12:31 PM

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
LLVMIR/
10 lines

Diff 541073

mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td

Show First 20 Lines • Show All 1,402 Lines • ▼ Show 20 Lines Arguments<(ins LLVM_i64ptr_shared:$dstMem,
Variadic<I32>:$coordinates)> { Variadic<I32>:$coordinates)> {
let assemblyFormat = "$dstMem `,` $tmaDescriptor `,` $mbar `,` `box` `[`$coordinates `]` attr-dict `:` type(operands)"; let assemblyFormat = "$dstMem `,` $tmaDescriptor `,` $mbar `,` `box` `[`$coordinates `]` attr-dict `:` type(operands)";
let extraClassDefinition = [{ let extraClassDefinition = [{
std::string $cppClass::getPtx() { std::string $cppClass::getPtx() {
int dim = getCoordinates().size(); int dim = getCoordinates().size();
std::string ptx = "cp.async.bulk.tensor."; std::string ptx = "cp.async.bulk.tensor.";
ptx += std::to_string(dim) + "d."; ptx += std::to_string(dim) + "d.";
ptx += "shared::cluster.global.mbarrier::complete_tx::bytes"; ptx += "shared::cluster.global.mbarrier::complete_tx::bytes";
if(dim == 1) ptx += " [%0], [%1, {%3}\], [%2];"; if(dim == 1) ptx += " [%0], [%1, {%3} ], [%2];";
if(dim == 2) ptx += " [%0], [%1, {%3, %4}\], [%2];"; if(dim == 2) ptx += " [%0], [%1, {%3, %4} ], [%2];";
if(dim == 3) ptx += " [%0], [%1, {%3, %4, %5}\], [%2];"; if(dim == 3) ptx += " [%0], [%1, {%3, %4, %5} ], [%2];";
if(dim == 4) ptx += " [%0], [%1, {%3, %4, %5, %6}\], [%2];"; if(dim == 4) ptx += " [%0], [%1, {%3, %4, %5, %6} ], [%2];";
if(dim == 5) ptx += " [%0], [%1, {%3, %4, %5, %6, %7}\], [%2];"; if(dim == 5) ptx += " [%0], [%1, {%3, %4, %5, %6, %7} ], [%2];";
return ptx; return ptx;
} }
}]; }];
let hasVerifier = 1; let hasVerifier = 1;
} }
#endif // NVVMIR_OPS #endif // NVVMIR_OPS