This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Include riscv32-unknown-elf target in Fuchsia toolchain
ClosedPublic

Authored by phosek on Jul 14 2023, 1:42 PM.

Diff Detail

Event Timeline

phosek created this revision.Jul 14 2023, 1:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2023, 1:42 PM
phosek requested review of this revision.Jul 14 2023, 1:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2023, 1:42 PM
mcgrathr accepted this revision.Jul 14 2023, 5:22 PM

It would be a better summary to say "include ... runtimes ...".

clang/cmake/caches/Fuchsia-stage2.cmake
10

Does this have any effect on what is included in any of the other target lib directories?

This revision is now accepted and ready to land.Jul 14 2023, 5:22 PM
phosek marked an inline comment as done.Jul 25 2023, 11:11 PM
phosek added inline comments.
clang/cmake/caches/Fuchsia-stage2.cmake
10

No, that's controlled by LLVM_ENABLE_RUNTIMES on individual targets, this is only needed for libc-hdrgen.

phosek reopened this revision.Aug 1 2023, 4:18 PM
phosek marked an inline comment as done.
This revision is now accepted and ready to land.Aug 1 2023, 4:18 PM