This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Remove the `LibC` subdirectory from the DeviceRTL
Needs ReviewPublic

Authored by jhuber6 on Jul 14 2023, 8:12 AM.

Details

Summary

This is redundant now that these functions are being implemented in the
GPU libc project https://libc.llvm.org/gpu/. Remove this to keep it
separate.

We do not need to do this immediately as it may regress for some people
until we do some more tests on including the libc in the upcoming
release.

Diff Detail

Event Timeline

jhuber6 created this revision.Jul 14 2023, 8:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2023, 8:12 AM
jhuber6 requested review of this revision.Jul 14 2023, 8:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2023, 8:12 AM

Let's defer the land of this patch until libc is enabled by default for OpenMP target offloading.

jhuber6 updated this revision to Diff 540456.Jul 14 2023, 9:27 AM

I don't know if we need to wait until it's the default, since this is probably a
niche usage and doesn't really belong here anyway. We can probably document how
to set this up, but we probably should wait until after the fork probably.

openmp/libomptarget/DeviceRTL/include/LibC.h