This is an archive of the discontinued LLVM Phabricator instance.

[lldb][LocateModuleCallback] Fix LocateModuleCallbackTest
ClosedPublic

Authored by splhack on Jul 12 2023, 4:02 PM.

Diff Detail

Event Timeline

splhack created this revision.Jul 12 2023, 4:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2023, 4:02 PM
splhack requested review of this revision.Jul 12 2023, 4:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2023, 4:02 PM
jasonmolenda accepted this revision.Jul 12 2023, 4:12 PM

unit tests pass clean with this patch, thanks! Maybe your mac build wasn't cmake'd with -DLLVM_ENABLE_ASSERTIONS=1 ?

This revision is now accepted and ready to land.Jul 12 2023, 4:12 PM

@jasonmolenda thanks for verifying this! and yes, I didn't realize -DLLVM_ENABLE_ASSERTIONS=1 is missing.

This revision was automatically updated to reflect the committed changes.