This is an archive of the discontinued LLVM Phabricator instance.

[lldb][Windows] Fix TestLocateModuleCallback
ClosedPublic

Authored by splhack on Jul 12 2023, 2:54 PM.

Details

Summary

D153735 added the tests but it is failing due to POSIX path vs Windows path.
https://lab.llvm.org/buildbot/#/builders/219/builds/4084

Fix it.

  • MODULE_PLATFORM_PATH is POSIX path.
  • Normalize self.input_dir, FileSpec and SymbolFileSpec fullpath.

Diff Detail

Event Timeline

splhack created this revision.Jul 12 2023, 2:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2023, 2:54 PM
splhack requested review of this revision.Jul 12 2023, 2:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2023, 2:54 PM
luporl added a subscriber: luporl.Jul 13 2023, 6:11 AM
luporl accepted this revision.Jul 14 2023, 4:50 AM

LGTM. It should fix the buildbot failure.

This revision is now accepted and ready to land.Jul 14 2023, 4:50 AM
This revision was automatically updated to reflect the committed changes.