Add more legal types for SMIN, SMAX, UMIN, UMAX in cost modelling for AArch64
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Thanks, Looks good. Can you split out the tests? I think this has included the two patches together.
And remember to upload with context. https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch
llvm/test/Analysis/CostModel/AArch64/sve-min-max.ll | ||
---|---|---|
2 | This can remove the --check-prefixes=CHECK,CHECK-NOF16, as it won't be needed for sve tests. | |
346 | And so this can be removed too. |
Comment Actions
Thanks. The SVE types could be predicated on hasSVE, but it doesn't make much sense to cost them without it.
LGTM
This can remove the --check-prefixes=CHECK,CHECK-NOF16, as it won't be needed for sve tests.