This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Fix cost modelling for SVE Min/Max Intrinsics
ClosedPublic

Authored by chuongg3 on Jul 6 2023, 9:24 AM.

Details

Summary

Add more legal types for SMIN, SMAX, UMIN, UMAX in cost modelling for AArch64

Diff Detail

Event Timeline

chuongg3 created this revision.Jul 6 2023, 9:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 9:24 AM
chuongg3 requested review of this revision.Jul 6 2023, 9:24 AM

Thanks, Looks good. Can you split out the tests? I think this has included the two patches together.

And remember to upload with context. https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch

llvm/test/Analysis/CostModel/AArch64/sve-min-max.ll
2

This can remove the --check-prefixes=CHECK,CHECK-NOF16, as it won't be needed for sve tests.

346

And so this can be removed too.

Matt added a subscriber: Matt.Jul 6 2023, 2:14 PM
chuongg3 updated this revision to Diff 538586.Jul 10 2023, 4:59 AM
chuongg3 added a reviewer: paulwalker-arm.

Removed arguments for the min/max test

dmgreen accepted this revision.Jul 11 2023, 7:52 AM

Thanks. The SVE types could be predicated on hasSVE, but it doesn't make much sense to cost them without it.

LGTM

This revision is now accepted and ready to land.Jul 11 2023, 7:52 AM
This revision was landed with ongoing or failed builds.Jul 11 2023, 11:46 PM
This revision was automatically updated to reflect the committed changes.