Add td definitions and asm/disasm tests for the dfp format
instructions in ISA 3.1 section 5.6.6
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
This looks good to me, just some request that can be done pre-commit
llvm/lib/Target/PowerPC/PPCInstrDFP.td | ||
---|---|---|
105–108 | I think we don't use these itineraries for these instructions at all right? Its still a bit odd to only apply the FPGeneral for the extract bias instructions only since all the others are also marked as "are treated as Floating-Point instructions in terms of resource availability.". Unless I misunderstood something about this instr specifically could you remove it here or apply it to each one, which ever you prefer. | |
105–126 | According to isa3.1 section. 5.6.7, only the first four instruction, encoding and decoding, may raise a floating point exception, these remaining ones need to moved outside of the } // mayRaiseFPException brace I think. |
I only have one minor nit.
Otherwise, LGTM!
Feel free to address the nit when you commit the patch.
llvm/lib/Target/PowerPC/PPCInstrDFP.td | ||
---|---|---|
145 | nit: |
I think we don't use these itineraries for these instructions at all right? Its still a bit odd to only apply the FPGeneral for the extract bias instructions only since all the others are also marked as "are treated as Floating-Point instructions in terms of resource availability.". Unless I misunderstood something about this instr specifically could you remove it here or apply it to each one, which ever you prefer.