This is an archive of the discontinued LLVM Phabricator instance.

[mlir][LLVM] Stop importing module location for all unknown locs
ClosedPublic

Authored by Dinistro on Jul 4 2023, 1:52 AM.

Details

Summary

This commit changes the LLVM IR import to use UnkownLoc for missing
debug locations. This change ensures that we do not accidentially
introduce failty locations that can influence debugging post export.

This behavior change is not applied to locations of global metadata
operations, as their location will not be exported.

Diff Detail

Event Timeline

Dinistro created this revision.Jul 4 2023, 1:52 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Dinistro requested review of this revision.Jul 4 2023, 1:52 AM
gysit accepted this revision.Jul 4 2023, 2:00 AM

LGTM!

This revision is now accepted and ready to land.Jul 4 2023, 2:00 AM