This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Add DFP quantum adjustment instruction definitions and MC tests
ClosedPublic

Authored by lei on Jul 3 2023, 10:12 AM.

Details

Summary

Add td definitions and asm/disasm tests for the quantum adjustment
instructions in ISA 3.1 section 5.6.4

Diff Detail

Event Timeline

lei created this revision.Jul 3 2023, 10:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 10:12 AM
lei requested review of this revision.Jul 3 2023, 10:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 10:12 AM
lei updated this revision to Diff 536939.Jul 3 2023, 8:05 PM

fix indentation

lei updated this revision to Diff 537072.Jul 4 2023, 5:58 AM

clang-format

I think this mostly looks good all I found was a couple of typos in two instructions.

llvm/lib/Target/PowerPC/PPCInstrDFP.td
183

Typo:
I think that this instruction is drrnd.

186

Typo:
This one too. I think it is drrndq.

lei added inline comments.Jul 4 2023, 9:37 AM
llvm/lib/Target/PowerPC/PPCInstrDFP.td
186

Ops ... thanks for catching that!

lei updated this revision to Diff 537121.Jul 4 2023, 9:50 AM

fix error in instruction name from drmd[q] to drrnd[q].

stefanp accepted this revision.Jul 4 2023, 10:02 AM

I have one more nit that I missed the first time around.

I will approve the patch and the nit can be addressed on commit.

llvm/lib/Target/PowerPC/PPCInstrDFP.td
185

nit:
Missed this the first time.
$FRA is actually f8rc.

This revision is now accepted and ready to land.Jul 4 2023, 10:02 AM
lei updated this revision to Diff 537129.Jul 4 2023, 10:47 AM

fix f8rc reg

lei updated this revision to Diff 537137.Jul 4 2023, 11:22 AM

Move class and multi class def.

stefanp accepted this revision.Jul 4 2023, 12:04 PM

LGTM.

This revision was landed with ongoing or failed builds.Jul 4 2023, 12:10 PM
This revision was automatically updated to reflect the committed changes.
lei marked 3 inline comments as done.