This is an archive of the discontinued LLVM Phabricator instance.

[Flang] Use llvm_unreachable to replace assert, NFC
ClosedPublic

Authored by lkail on Jul 3 2023, 6:39 AM.

Details

Reviewers
pscoro
kkwli0
Group Reviewers
Restricted Project
Commits
rGfb09f9f91411: [Flang] Use llvm_unreachable to replace assert, NFC
Summary

IIUC, the default case should be unreachable inferred from the context.

Diff Detail

Event Timeline

lkail created this revision.Jul 3 2023, 6:39 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 3 2023, 6:39 AM
lkail requested review of this revision.Jul 3 2023, 6:39 AM
lkail retitled this revision from [Flang] Use llvm_unreachable to replace assert to [Flang] Use llvm_unreachable to replace assert, NFC.Jul 3 2023, 6:48 AM
lkail edited the summary of this revision. (Show Details)
kkwli0 accepted this revision.Jul 3 2023, 7:25 AM

LTGM. Thanks

This revision is now accepted and ready to land.Jul 3 2023, 7:25 AM
This revision was automatically updated to reflect the committed changes.