This is an archive of the discontinued LLVM Phabricator instance.

[LoongArch] Replace OperandMatchResultTy with ParseStatus (NFC)
ClosedPublic

Authored by barannikov88 on Jul 2 2023, 8:46 PM.

Details

Summary

ParseStatus is slightly more convenient to use due to implicit
conversion from bool, which allows to do something like:

return Error(L, "msg");

when with MatchOperandResultTy it had to be:

Error(L, "msg");
return MatchOperand_ParseFail;

It also has more appropriate name since parse* methods are not only for
parsing operands.

Diff Detail

Event Timeline

barannikov88 created this revision.Jul 2 2023, 8:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2023, 8:46 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
barannikov88 requested review of this revision.Jul 2 2023, 8:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2023, 8:46 PM
xen0n accepted this revision.Jul 2 2023, 9:25 PM

Seems good from a cursory look. Thanks!

This revision is now accepted and ready to land.Jul 2 2023, 9:25 PM