This is an archive of the discontinued LLVM Phabricator instance.

[flang][hlfir] Set/propagate 'unordered' attribute for elementals.
ClosedPublic

Authored by vzakhari on Jun 28 2023, 5:50 PM.

Details

Summary

This patch adds 'unordered' attribute handling the HLFIR elementals'
builders and fixes the attribute handling in lowering and transformations.

Depends on D154031, D154032

Diff Detail

Event Timeline

vzakhari created this revision.Jun 28 2023, 5:50 PM
vzakhari requested review of this revision.Jun 28 2023, 5:50 PM
jeanPerier accepted this revision.Jun 28 2023, 11:55 PM

Looks great, thanks a lot for chasing all the spots where the attribute had to be propagated/set!

flang/lib/Lower/ConvertArrayConstructor.cpp
690

Did you mean the reverse: is always ordered -> is always unordered ?

This revision is now accepted and ready to land.Jun 28 2023, 11:55 PM
tblah accepted this revision.Jun 29 2023, 2:52 AM

Looks good to me!

vzakhari added inline comments.Jun 29 2023, 9:36 AM
flang/lib/Lower/ConvertArrayConstructor.cpp
690

Right! Thanks!