This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy] Add LoongArch support
ClosedPublic

Authored by xen0n on Jun 22 2023, 10:48 PM.

Details

Summary

Apart from general feature parity, this is also necessary for enabling
ClangBuiltLinux that defaults to using LLVM tools.

While at it, add a missing comment for the Hexagon definition directly
above, so it doesn't get confused with the SPARC definitions.

Diff Detail

Unit TestsFailed

Event Timeline

xen0n created this revision.Jun 22 2023, 10:48 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: emaste. · View Herald Transcript
xen0n requested review of this revision.Jun 22 2023, 10:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2023, 10:48 PM
jhenderson accepted this revision.Jun 23 2023, 12:02 AM

LGTM.

llvm/tools/llvm-objcopy/ObjcopyOptions.cpp
335–338

Whilst you're in the area, would you mind please adding the missing // Hexagon comment? It just helps readability of this table, and means Hexagon doesn't look like it's a variation on SPARC!

This revision is now accepted and ready to land.Jun 23 2023, 12:02 AM
xen0n updated this revision to Diff 533879.Jun 23 2023, 12:43 AM

Drive-by fix adding a comment to the Hexagon definition line.

xen0n marked an inline comment as done.Jun 23 2023, 12:44 AM
xen0n added inline comments.
llvm/tools/llvm-objcopy/ObjcopyOptions.cpp
335–338

No problem; thanks for the suggestion! This is now added.

xen0n edited the summary of this revision. (Show Details)Jun 23 2023, 12:45 AM
xen0n marked an inline comment as done.Jun 23 2023, 12:45 AM
MaskRay accepted this revision.Jun 23 2023, 5:54 PM
SixWeining accepted this revision.Jun 23 2023, 9:49 PM
This revision was landed with ongoing or failed builds.Jun 25 2023, 7:38 PM
This revision was automatically updated to reflect the committed changes.