[flang] Enhance getTypeAsString for RecordType

[clementval]

Summary

Add support for RecordType in getTypeAsString

Depends on D153461

[jeanPerier]

What is the motivation to use the component type for the name instead of the record type name instead?
Is it a goal that two derived types with the same components get the same name, won't the openacc recipe argument record type clash?

[clementval]

In D153467#4440050, @jeanPerier wrote:

What is the motivation to use the component type for the name instead of the record type name instead?
Is it a goal that two derived types with the same components get the same name, won't the openacc recipe argument record type clash?

Thinking about this again, using just the name should be enough. At least for now.

[clementval]

Use record tyep name

[razvanlupusoru]

Although technically it would be useful to reuse recipe for similar types, seems most useful to use record name. Looks good to me in its current form.

[jeanPerier]

In D153467#4443415, @razvanlupusoru wrote:

Although technically it would be useful to reuse recipe for similar types, seems most useful to use record name. Looks good to me in its current form.

Another point is that similar type may have different user defined assignments, initial values and final routines (not sure if this matter in the recipes though).

[jeanPerier]

LGTM

flang/lib/Optimizer/Dialect/FIRType.cpp

if (fir::isa_ref_type(ty))
     return CFI_type_cptr;
   if (ty.isa<fir::RecordType>())
     return CFI_type_struct;
   llvm_unreachable("unsupported type");
 }
 
 std::string getTypeAsString(mlir::Type ty, const fir::KindMapping &kindMap,
                             llvm::StringRef prefix) {
-  std::stringstream name;
+  std::string buf;
+  llvm::raw_string_ostream name{buf};
   name << prefix.str();
   if (!prefix.empty())
     name << "_";
   while (ty) {
     if (fir::isa_trivial(ty)) {
       if (mlir::isa<mlir::IndexType>(ty)) {
         name << "idx";
       } else if (ty.isIntOrIndex()) {
if (fir::isa_trivial(ty)) {
       name << "heap_";
       ty = heapTy.getEleTy();
     } else if (auto classTy = mlir::dyn_cast_or_null<fir::ClassType>(ty)) {
       name << "class_";
       ty = classTy.getEleTy();
     } else if (auto boxTy = mlir::dyn_cast_or_null<fir::BoxType>(ty)) {
       name << "box_";
       ty = boxTy.getEleTy();
+    } else if (auto recTy = mlir::dyn_cast_or_null<fir::RecordType>(ty)) {
+      name << "rec_" << recTy.getName();
+      break;
     } else {
-      // TODO: add support for RecordType
       llvm::report_fatal_error("unsupported type");
     }
   }
   return name.str();
 }
 
 } // namespace fir
 

flang/unittests/Optimizer/FIRTypesTest.cpp

EXPECT_EQ("box_i32",
       fir::getTypeAsString(
           fir::BoxType::get(mlir::IntegerType::get(&context, 32)), *kindMap));
   EXPECT_EQ("class_i32",
       fir::getTypeAsString(
           fir::ClassType::get(mlir::IntegerType::get(&context, 32)), *kindMap));
   EXPECT_EQ("class_none",
       fir::getTypeAsString(
           fir::ClassType::get(mlir::NoneType::get(&context)), *kindMap));
+  auto derivedTy = fir::RecordType::get(&context, "derived");
+  llvm::SmallVector<std::pair<std::string, mlir::Type>> components;
+  components.emplace_back("p1", mlir::IntegerType::get(&context, 64));
+  derivedTy.finalize({}, components);
+  EXPECT_EQ("rec_derived", fir::getTypeAsString(derivedTy, *kindMap));
 }