This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Make sure our .clang-format is used for all languages
ClosedPublic

Authored by ldionne on Jun 19 2023, 8:22 AM.

Details

Summary

In particular, this ensures that it is used for Objective-C and
Objective-C++, since we have a few files that get detected as that.

Diff Detail

Event Timeline

ldionne created this revision.Jun 19 2023, 8:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 8:22 AM
ldionne requested review of this revision.Jun 19 2023, 8:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 8:22 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Jun 19 2023, 8:29 AM
This revision is now accepted and ready to land.Jun 19 2023, 8:29 AM
Mordante accepted this revision.Jun 19 2023, 8:30 AM
Mordante added a subscriber: Mordante.

Thanks! LGTM!

libcxx/.clang-format
72

Can you add a comment here why we don't specify the language.
Just to avoid somebody trying to fix this "omission" in the future.

ldionne marked an inline comment as done.Jun 19 2023, 10:10 AM
ldionne updated this revision to Diff 532701.Jun 19 2023, 10:11 AM

Rebase, address comment and reformat __config, which was not being detected as C++ anymore so wasn't getting formatted.

ldionne updated this revision to Diff 532935.Jun 20 2023, 7:55 AM

Update ignore_format.txt