This is an archive of the discontinued LLVM Phabricator instance.

[llvm][test] Update SPL Vectorizer X86 metadata test to use check-globals
AcceptedPublic

Authored by jmciver on Jun 16 2023, 5:32 PM.

Details

Summary

The SPL Vectorizer X86 metadata test is updated to use update_test_checks.py
with the check-globals option. This replaces the metadata CHECK-DAG statements
with generated expressions.

Diff Detail

Event Timeline

jmciver created this revision.Jun 16 2023, 5:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2023, 5:32 PM
Herald added a subscriber: pengfei. · View Herald Transcript
jmciver added a subscriber: nlopes.
jmciver published this revision for review.Jun 16 2023, 8:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2023, 8:27 PM
jmciver retitled this revision from [NFC][llvm] Update SPL Vectorizer X86 metadata test to use check-globals to [llvm][test] Update SPL Vectorizer X86 metadata test to use check-globals.Jun 20 2023, 7:45 PM
jdoerfert accepted this revision.Jun 20 2023, 7:45 PM
This revision is now accepted and ready to land.Jun 20 2023, 7:45 PM
jmciver updated this revision to Diff 533109.EditedJun 20 2023, 8:00 PM

Regenerating test using D148216

@jdoerfert thanks for the LGTM!

This patch was originally linked to D153190, but as @nikic pointed out D148216 will supersede D153190 by providing a generic solution.

I have arc patched and tested against D148216, which changes the variable names slightly. I am going to add D148216 as a parent and wait for it to land before landing this patch.