This is an archive of the discontinued LLVM Phabricator instance.

[mlir][linalg] Fix linalg.conv vectorization for mixed int-fp types
ClosedPublic

Authored by rsuderman on Jun 14 2023, 4:59 PM.

Details

Summary

We always assume mixed same type values. Instead of ExtF or ExtSI, we
need SIToFp when the values must be promoted.

Diff Detail

Event Timeline

rsuderman created this revision.Jun 14 2023, 4:59 PM
Herald added a project: Restricted Project. · View Herald Transcript
rsuderman requested review of this revision.Jun 14 2023, 4:59 PM
dcaballe accepted this revision.Jun 15 2023, 10:07 AM

LGTM! Just one comments. THank!

mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
2753–2763

Could you please also add an extra condition to these if statements to make sure that both dst and src have the expected type? IIUC, we were incorrectly going through one of them and not hitting the assert below.

This revision is now accepted and ready to land.Jun 15 2023, 10:07 AM

Add matching element type

rsuderman marked an inline comment as done.Jun 15 2023, 10:53 AM
dcaballe accepted this revision.Jun 15 2023, 10:57 AM
This revision was landed with ongoing or failed builds.Jun 15 2023, 11:15 AM
This revision was automatically updated to reflect the committed changes.