This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][MC] Fix encoding for vfwmaccbf16
ClosedPublic

Authored by asb on Jun 14 2023, 2:13 AM.

Details

Summary

The encoding matched the one given in the bf16 extension specification PDF, but per https://github.com/riscv/riscv-bfloat16/issues/45 it seems this encoding was not the one that is intended and was incorrectly modified due to an issue in the PDF generation process. This patch corrects the opcode to 111011 from 100011.

Diff Detail

Event Timeline

asb created this revision.Jun 14 2023, 2:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2023, 2:13 AM
asb requested review of this revision.Jun 14 2023, 2:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2023, 2:13 AM
This revision is now accepted and ready to land.Jun 16 2023, 11:52 AM
reames accepted this revision.Jun 22 2023, 1:23 PM

It looks like the PDF has been updated, so LGTM by me as well.

This revision was landed with ongoing or failed builds.Jun 23 2023, 6:02 AM
This revision was automatically updated to reflect the committed changes.