This is an archive of the discontinued LLVM Phabricator instance.

Differential D152616

[AMDGPU] Stop hardcoding v_mov_b32 in VOPD. NFCI.
ClosedPublic

Authored by rampitec on Jun 10 2023, 3:24 AM.

Details

Reviewers
foad
Joe_Nash
arsenm
Commits
rG31286329dd7c: [AMDGPU] Stop hardcoding v_mov_b32 in VOPD. NFCI.
Summary

There is no single possible reason to to it.

Diff Detail

Unit TestsFailed

TimeTest
60,070 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

rampitec created this revision.Jun 10 2023, 3:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 3:24 AM
Herald added subscribers: StephenFan, kerbowa, hiraditya and 6 others. · View Herald Transcript
rampitec requested review of this revision.Jun 10 2023, 3:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2023, 3:24 AM
Herald added a subscriber: wdng. · View Herald Transcript
Harbormaster completed remote builds in B237944: Diff 530191.Jun 10 2023, 4:02 AM
arsenm accepted this revision.Jun 10 2023, 4:51 AM
This revision is now accepted and ready to land.Jun 10 2023, 4:51 AM
This revision was landed with ongoing or failed builds.Jun 10 2023, 11:24 AM
Closed by commit rG31286329dd7c: [AMDGPU] Stop hardcoding v_mov_b32 in VOPD. NFCI. (authored by rampitec). · Explain Why
This revision was automatically updated to reflect the committed changes.
rampitec added a commit: rG31286329dd7c: [AMDGPU] Stop hardcoding v_mov_b32 in VOPD. NFCI..

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
2 lines

Diff 530191

llvm/lib/Target/AMDGPU/VOP1Instructions.td

Show First 20 Lines • Show All 114 Lines • ▼ Show 20 Linesmulticlass VOP1Inst <string opName, VOPProfile P,
defvar should_mov_imm = !or(!eq(opName, "v_mov_b32"), defvar should_mov_imm = !or(!eq(opName, "v_mov_b32"),
!eq(opName, "v_mov_b64")); !eq(opName, "v_mov_b64"));
let isMoveImm = should_mov_imm in { let isMoveImm = should_mov_imm in {
if !eq(VOPDOp, -1) then if !eq(VOPDOp, -1) then
def _e32 : VOP1_Pseudo <opName, P>; def _e32 : VOP1_Pseudo <opName, P>;
else else
// Only for V_MOV_B32 // Only for V_MOV_B32
def _e32 : VOP1_Pseudo <opName, P>, VOPD_Component<VOPDOp, "v_mov_b32">; def _e32 : VOP1_Pseudo <opName, P>, VOPD_Component<VOPDOp, opName>;
def _e64 : VOP3InstBase <opName, P, node>; def _e64 : VOP3InstBase <opName, P, node>;
} }
if P.HasExtSDWA then if P.HasExtSDWA then
def _sdwa : VOP1_SDWA_Pseudo <opName, P>; def _sdwa : VOP1_SDWA_Pseudo <opName, P>;
if P.HasExtDPP then if P.HasExtDPP then
def _dpp : VOP1_DPP_Pseudo <opName, P>; def _dpp : VOP1_DPP_Pseudo <opName, P>;
▲ Show 20 Lines • Show All 1,174 Lines • Show Last 20 Lines