[mlir][vector][transform] Drop redundant "apply_" from op names

[springerm]

Summary

This is for consistency with the other ops.

mlir/include/mlir/Dialect/Vector/TransformOps/VectorTransformOps.td

 
 include "mlir/Dialect/Transform/IR/TransformDialect.td"
 include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
 include "mlir/Dialect/Vector/Transforms/VectorTransformsBase.td"
 include "mlir/Interfaces/SideEffectInterfaces.td"
 include "mlir/IR/OpBase.td"
 
 def ApplyRankReducingSubviewPatternsOp : Op<Transform_Dialect,
-    "apply_patterns.vector.apply_rank_reducing_subview_patterns",
+    "apply_patterns.vector.rank_reducing_subview_patterns",
     [DeclareOpInterfaceMethods<PatternDescriptorOpInterface>]> {
   let description = [{
     Apply opt-in vector transfer permutation patterns that include:
       - TransferReadDropUnitDimsPattern
       - TransferWriteDropUnitDimsPattern
 
     These patterns have the effect of rewriting a vector.transfer with unit
     dimensions into a rank-reduced version thanks to subview operations.
     This is complemented by shape_cast folding patterns.
   }];
 
   let assemblyFormat = "attr-dict";
 }
 
 def ApplyTransferPermutationPatternsOp : Op<Transform_Dialect,
-    "apply_patterns.vector.apply_transfer_permutation_patterns",
+    "apply_patterns.vector.transfer_permutation_patterns",
     [DeclareOpInterfaceMethods<PatternDescriptorOpInterface>]> {
   let description = [{
     Apply opt-in vector transfer permutation patterns that include:
       - TransferReadPermutationLowering
       - TransferWritePermutationLowering
       - TransferOpReduceRank
       - TransferWriteNonPermutationLowering
 

mlir/test/Dialect/LLVM/transform-e2e.mlir

^bb1(%module_op: !transform.any_op):
 
   // TODO: group these lower-level controls into various properly named vector
   // lowering TD macros.
   transform.apply_patterns to %f {
     transform.apply_patterns.vector.lower_contraction lowering_strategy = "outerproduct"
   } : !transform.any_op
 
   transform.apply_patterns to %f {
-    transform.apply_patterns.vector.apply_transfer_permutation_patterns
+    transform.apply_patterns.vector.transfer_permutation_patterns
   } : !transform.any_op
 
   transform.apply_patterns to %f {
     transform.apply_patterns.vector.lower_multi_reduction lowering_strategy = "innerparallel"
   } : !transform.any_op
 
   transform.apply_patterns to %f {
     transform.apply_patterns.vector.split_transfer_full_partial split_transfer_strategy = "linalg-copy"

mlir/test/Dialect/Vector/transform-vector.mlir

^bb1(%module_op: !transform.any_op):
 
   // TODO: group these lower-level controls into various properly named vector
   // lowering TD macros.
   transform.apply_patterns to %f {
     transform.apply_patterns.vector.lower_contraction lowering_strategy = "outerproduct"
   } : !transform.any_op
 
   transform.apply_patterns to %f {
-    transform.apply_patterns.vector.apply_transfer_permutation_patterns
+    transform.apply_patterns.vector.transfer_permutation_patterns
   } : !transform.any_op
 
   transform.apply_patterns to %f {
     transform.apply_patterns.vector.lower_multi_reduction lowering_strategy = "innerparallel"
   } : !transform.any_op
 
   transform.apply_patterns to %f {
     transform.apply_patterns.vector.split_transfer_full_partial split_transfer_strategy = "linalg-copy"

mlir/test/Dialect/Vector/vector-transfer-drop-unit-dims-patterns.mlir

 //  CHECK-SAME:     %[[ARG:.+]]: memref<1x1x3x2xi8
 //       CHECK:   %[[SUBVIEW:.+]] = memref.subview %[[ARG]][0, 0, 0, 0] [1, 1, 3, 2] [1, 1, 1, 1]
 //  CHECK-SAME:     memref<1x1x3x2xi8, {{.*}}> to memref<3x2xi8, {{.*}}>
 //       CHECK:   vector.transfer_read %[[SUBVIEW]]
 
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
-    transform.apply_patterns.vector.apply_rank_reducing_subview_patterns
+    transform.apply_patterns.vector.rank_reducing_subview_patterns
   } : !transform.any_op
 }
 
 // -----
 
 func.func @transfer_write_rank_reducing(%arg : memref<1x1x3x2xi8, strided<[6, 6, 2, 1], offset: ?>>, %vec : vector<3x2xi8>) {
     %c0 = arith.constant 0 : index
     vector.transfer_write %vec, %arg [%c0, %c0, %c0, %c0] :
       vector<3x2xi8>, memref<1x1x3x2xi8, strided<[6, 6, 2, 1], offset: ?>>
     return
 }
 
 // CHECK-LABEL: func @transfer_write_rank_reducing
 //  CHECK-SAME:     %[[ARG:.+]]: memref<1x1x3x2xi8
 //       CHECK:   %[[SUBVIEW:.+]] = memref.subview %[[ARG]][0, 0, 0, 0] [1, 1, 3, 2] [1, 1, 1, 1]
 //  CHECK-SAME:     memref<1x1x3x2xi8, {{.*}}> to memref<3x2xi8, {{.*}}>
 //       CHECK:   vector.transfer_write %{{.*}}, %[[SUBVIEW]]
 
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
-    transform.apply_patterns.vector.apply_rank_reducing_subview_patterns
+    transform.apply_patterns.vector.rank_reducing_subview_patterns
   } : !transform.any_op
 }
 
 // -----
 
 func.func @transfer_read_and_vector_rank_reducing(
       %arg : memref<1x1x3x2x1xf32>) -> vector<3x2x1xf32> {
     %c0 = arith.constant 0 : index
     %cst = arith.constant 0.0 : f32
     %v = vector.transfer_read %arg[%c0, %c0, %c0, %c0, %c0], %cst :
       memref<1x1x3x2x1xf32>, vector<3x2x1xf32>
     return %v : vector<3x2x1xf32>
 }
 
 // CHECK-LABEL: func @transfer_read_and_vector_rank_reducing
 //  CHECK-SAME:     %[[ARG:.+]]: memref<1x1x3x2x1xf32>
 //       CHECK:   %[[SUBVIEW:.+]] = memref.subview %[[ARG]][0, 0, 0, 0, 0] [1, 1, 3, 2, 1] [1, 1, 1, 1, 1]
 //  CHECK-SAME:     memref<1x1x3x2x1xf32> to memref<3x2xf32>
 //       CHECK:   vector.transfer_read %[[SUBVIEW]]{{.*}} {in_bounds = [true, true]} : memref<3x2xf32>, vector<3x2xf32>
 
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
-    transform.apply_patterns.vector.apply_rank_reducing_subview_patterns
+    transform.apply_patterns.vector.rank_reducing_subview_patterns
   } : !transform.any_op
 }
 
 // -----
 
 func.func @transfer_write_and_vector_rank_reducing(
       %arg : memref<1x1x3x2x1xf32>,
       %vec : vector<3x2x1xf32>) {
     %c0 = arith.constant 0 : index
     vector.transfer_write %vec, %arg [%c0, %c0, %c0, %c0, %c0] :
       vector<3x2x1xf32>, memref<1x1x3x2x1xf32>
     return
 }
 
 // CHECK-LABEL: func @transfer_write_and_vector_rank_reducing
 //  CHECK-SAME:     %[[ARG:.+]]: memref<1x1x3x2x1xf32>
 //       CHECK:   %[[SUBVIEW:.+]] = memref.subview %[[ARG]][0, 0, 0, 0, 0] [1, 1, 3, 2, 1] [1, 1, 1, 1, 1]
 //  CHECK-SAME:     memref<1x1x3x2x1xf32> to memref<3x2xf32>
 //       CHECK:   vector.transfer_write %{{.*}}, %[[SUBVIEW]]{{.*}} {in_bounds = [true, true]} : vector<3x2xf32>, memref<3x2xf32>
 
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
-    transform.apply_patterns.vector.apply_rank_reducing_subview_patterns
+    transform.apply_patterns.vector.rank_reducing_subview_patterns
   } : !transform.any_op
 }
 
 // -----
 
 func.func @transfer_read_and_vector_rank_reducing_to_0d(
       %arg : memref<1x1x1x1x1xf32>) -> vector<1x1x1xf32> {
     %c0 = arith.constant 0 : index
     %cst = arith.constant 0.0 : f32
     %v = vector.transfer_read %arg[%c0, %c0, %c0, %c0, %c0], %cst :
       memref<1x1x1x1x1xf32>, vector<1x1x1xf32>
     return %v : vector<1x1x1xf32>
 }
 
 // CHECK-LABEL: func @transfer_read_and_vector_rank_reducing_to_0d
 //  CHECK-SAME:     %[[MEMREF:.+]]: memref<1x1x1x1x1xf32>
 //       CHECK:   %[[SUBVIEW:.+]] = memref.subview %[[MEMREF]][0, 0, 0, 0, 0] [1, 1, 1, 1, 1] [1, 1, 1, 1, 1] : memref<1x1x1x1x1xf32> to memref<f32>
 //       CHECK:   %[[READ:.+]] = vector.transfer_read %[[SUBVIEW]]{{.*}} : memref<f32>, vector<f32>
 //       CHECK:   vector.shape_cast %[[READ]] : vector<f32> to vector<1x1x1xf32>
 
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
-    transform.apply_patterns.vector.apply_rank_reducing_subview_patterns
+    transform.apply_patterns.vector.rank_reducing_subview_patterns
   } : !transform.any_op
 }
 
 // -----
 
 func.func @transfer_write_and_vector_rank_reducing_to_0d(
       %arg : memref<1x1x1x1x1xf32>,
       %vec : vector<1x1x1xf32>) {
     %c0 = arith.constant 0 : index
     vector.transfer_write %vec, %arg [%c0, %c0, %c0, %c0, %c0] :
       vector<1x1x1xf32>, memref<1x1x1x1x1xf32>
     return
 }
 
 // CHECK-LABEL: func @transfer_write_and_vector_rank_reducing_to_0d
 //  CHECK-SAME:     %[[MEMREF:.+]]: memref<1x1x1x1x1xf32>, %[[VECTOR:.+]]: vector<1x1x1xf32>
 //       CHECK:   %[[SUBVIEW:.+]] = memref.subview %[[MEMREF]][0, 0, 0, 0, 0] [1, 1, 1, 1, 1] [1, 1, 1, 1, 1] : memref<1x1x1x1x1xf32> to memref<f32>
 //       CHECK:   %[[SHCAST:.+]] = vector.shape_cast %[[VECTOR]] : vector<1x1x1xf32> to vector<f32>
 //       CHECK:   vector.transfer_write %[[SHCAST]], %[[SUBVIEW]]{{.*}} : vector<f32>, memref<f32>
 
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
-    transform.apply_patterns.vector.apply_rank_reducing_subview_patterns
+    transform.apply_patterns.vector.rank_reducing_subview_patterns
   } : !transform.any_op
 }

mlir/test/Dialect/Vector/vector-transfer-to-vector-load-store.mlir

func.func @transfer_broadcasting_complex(%mem : memref<10x20x30x8x8xf32>, %i : index) -> vector<3x2x4x5xf32> {
   return %res : vector<3x2x4x5xf32>
 }
 
 
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
     transform.apply_patterns.vector.lower_transfer max_transfer_rank = 99
-    transform.apply_patterns.vector.apply_transfer_permutation_patterns
+    transform.apply_patterns.vector.transfer_permutation_patterns
   } : !transform.any_op
 }
 
 // -----
 
 #map0 = affine_map<(d0, d1, d2, d3) -> (d1, d0, 0, 0)>
 #map1 = affine_map<(d0, d1, d2, d3) -> (0, d1, 0, d0)>
 #map2 = affine_map<(d0, d1, d2, d3) -> (d3, d1, 0, 0)>
func.func @transfer_write_broadcast_unit_dim(
 
   return %0 : tensor<?x?x?x?xf32>
 }
 
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
     transform.apply_patterns.vector.lower_transfer max_transfer_rank = 99
-    transform.apply_patterns.vector.apply_transfer_permutation_patterns
+    transform.apply_patterns.vector.transfer_permutation_patterns
   } : !transform.any_op
 }