This is an archive of the discontinued LLVM Phabricator instance.

[mlir][transform] Use separate ops instead of PatternRegistry
ClosedPublic

Authored by springerm on Jun 6 2023, 2:20 AM.

Details

Summary
  • Remove transform::PatternRegistry.
  • Add a new op for each currently registered pattern set.
  • Change names of vector dialect pattern selector ops, so that they are consistent with the remaining code base.
  • Remove redundant transform.vector.extract_address_computations op.

Diff Detail

Event Timeline

springerm created this revision.Jun 6 2023, 2:20 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
springerm requested review of this revision.Jun 6 2023, 2:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2023, 2:20 AM
ftynse accepted this revision.Jun 6 2023, 2:39 AM
ftynse added inline comments.
mlir/test/Dialect/MemRef/extract-address-computations.mlir
60

Nit: something went wrong with formatting, the trailing } belongs to the next line.

This revision is now accepted and ready to land.Jun 6 2023, 2:39 AM
This revision was landed with ongoing or failed builds.Jun 6 2023, 2:54 AM
This revision was automatically updated to reflect the committed changes.
springerm marked an inline comment as done.