This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][NFC] Normalise name of indexed forms of SQRDMLAH/SQRDMLSH
ClosedPublic

Authored by rjj on Jun 5 2023, 6:49 AM.

Details

Summary

Most indexed vector instructions are suffixed with v<N><TY>_indexed.

SQRDMLAH/SQRDMLSH are the exception—they are suffixed with <TY>_indexed.
This can complicate matching slightly.

Diff Detail

Event Timeline

rjj created this revision.Jun 5 2023, 6:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 6:49 AM
rjj requested review of this revision.Jun 5 2023, 6:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 6:49 AM
dmgreen accepted this revision.Jun 5 2023, 9:36 AM

Thanks. There is a mention of i32_indexed in llvm/test/CodeGen/AArch64/arm64-neon-v8.1a.ll that looks like it references the same thing. Other than that I agree this looks better.

Thanks for splitting it out. LGTM.

This revision is now accepted and ready to land.Jun 5 2023, 9:36 AM
rjj updated this revision to Diff 528815.Jun 6 2023, 5:49 AM
  • Update mention in llvm/test/CodeGen/AArch64/arm64-neon-v8.1a.ll
rjj added a comment.Jun 6 2023, 5:52 AM

Thanks. There is a mention of i32_indexed in llvm/test/CodeGen/AArch64/arm64-neon-v8.1a.ll that looks like it references the same thing. Other than that I agree this looks better.

Thanks for splitting it out. LGTM.

Thanks very much, I've updated llvm/test/CodeGen/AArch64/arm64-neon-v8.1a.ll too!

This revision was landed with ongoing or failed builds.Jun 6 2023, 6:03 AM
This revision was automatically updated to reflect the committed changes.