This is an archive of the discontinued LLVM Phabricator instance.

[clang] Use `FileEntryRef` in modular header search (part 1/2)
ClosedPublic

Authored by jansvoboda11 on May 31 2023, 4:29 PM.

Details

Summary

This patch removes some deprecated uses of {File,Directory}Entry::getName(). No functional change indended.

Depends on D151853.

Diff Detail

Event Timeline

jansvoboda11 created this revision.May 31 2023, 4:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2023, 4:29 PM
jansvoboda11 requested review of this revision.May 31 2023, 4:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2023, 4:29 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
clang/include/clang/Lex/HeaderSearch.h
763

This should probably be non-Optional. I can't find any calls to this API that can pass null, they all pass something that is already being dereferenced.

jansvoboda11 added inline comments.Jun 1 2023, 10:29 AM
clang/include/clang/Lex/HeaderSearch.h
763

You're right, thanks. Fixed in the committed version.

763

*In the new revision, rather.

Remove optionality from one argument

benlangmuir accepted this revision.Jun 1 2023, 10:31 AM
This revision is now accepted and ready to land.Jun 1 2023, 10:31 AM
This revision was landed with ongoing or failed builds.Jun 1 2023, 10:38 AM
This revision was automatically updated to reflect the committed changes.