Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D151931

[clang] Remove `DirectoryEntry::getName()`
Needs ReviewPublic
Actions

Authored by jansvoboda11 on Jun 1 2023, 1:50 PM.

Details

Reviewers
benlangmuir
bnbarham
Summary

This patch finally removes the deprecated DirectoryEntry::getName() function.

Depends on D151927.

Diff Detail

Event Timeline

jansvoboda11 created this revision.Jun 1 2023, 1:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 1:50 PM
Herald added a subscriber: ributzka. · View Herald Transcript
jansvoboda11 requested review of this revision.Jun 1 2023, 1:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 1:50 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
benlangmuir added a comment.Jun 1 2023, 1:53 PM

Given this was a commonly used function before and there's a decent chance it's used out of tree somewhere, should we wait until the next llvm release branch has been cut before landing this?

jansvoboda11 added a comment.Jun 1 2023, 2:02 PM

Yes, I'd like to get the deprecation (and fixes in other LLVM sub-projects) into main ASAP and then land this patch after the branch for the 17 release is cut.

Harbormaster completed remote builds in B235972: Diff 527598.Jun 1 2023, 7:14 PM

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
Basic/
7 lines
lib/
Basic/
2 lines

Diff 527598

View Options

clang/include/clang/Basic/DirectoryEntry.h

Loading...
View Options

clang/lib/Basic/FileManager.cpp

Loading...